GH-38366: [Java] Fix Murmur hash on buffers less than 4 bytes #38368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lidavidm
changed the title
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4bbd48d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <[email protected]> Signed-off-by: David Li <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 25, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <[email protected]> Signed-off-by: David Li <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <[email protected]> Signed-off-by: David Li <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Using the
MurmurHashimplementation would cause collisions on small input values.What changes are included in this PR?
Fix the iteration for small and tail values that are not 4 bytes in length.
Are these changes tested?
Yes
Are there any user-facing changes?
Unlikely unless someone was using the
MurmurHashfunctions to persist a hash value.