GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test #38347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
wgtmac
changed the title
pitrou
approved these changes
Oct 24, 2023
github-actions
bot
added
awaiting committer review
mapleFU
approved these changes
Oct 24, 2023
|
Will merge it if nobody has more comment tonight |
|
CI faileds are unrelated. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 25, 2023
… encryption test (apache#38347) ### Rationale for this change Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index. ### What changes are included in this PR? Minor refactor read_configurations_test.cc to check page index from all parquet files. ### Are these changes tested? This is indeed a unit test enhancement. ### Are there any user-facing changes? NO. * Closes: apache#38346 Authored-by: Gang Wu <[email protected]> Signed-off-by: mwish <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit e836061. There were 9 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
… encryption test (apache#38347) ### Rationale for this change Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index. ### What changes are included in this PR? Minor refactor read_configurations_test.cc to check page index from all parquet files. ### Are these changes tested? This is indeed a unit test enhancement. ### Are there any user-facing changes? NO. * Closes: apache#38346 Authored-by: Gang Wu <[email protected]> Signed-off-by: mwish <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… encryption test (apache#38347) ### Rationale for this change Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index. ### What changes are included in this PR? Minor refactor read_configurations_test.cc to check page index from all parquet files. ### Are these changes tested? This is indeed a unit test enhancement. ### Are there any user-facing changes? NO. * Closes: apache#38346 Authored-by: Gang Wu <[email protected]> Signed-off-by: mwish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.
What changes are included in this PR?
Minor refactor read_configurations_test.cc to check page index from all parquet files.
Are these changes tested?
This is indeed a unit test enhancement.
Are there any user-facing changes?
NO.