GH-38326: [C++][Parquet] check the decompressed page size same as size in page header #38327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
pitrou
reviewed
Oct 18, 2023
github-actions
bot
added
awaiting committer review
|
Can you perhaps try reading some third-party Parquet files with this, if you can find some? |
|
Let me generate a hand-written compression file with "bad" header |
mapleFU
commented
Oct 18, 2023
mapleFU
force-pushed
the
check-decompress-size
branch
from
4218afd to
98d047b
Compare
mapleFU
commented
Oct 18, 2023
Comment on lines
+913
to
+914
| // Some decompressor, like zstd, might be able to detect the error | ||
| // before checking the page size. |
There was a problem hiding this comment.
ZSTD would throw an IOError: Corrupt ... here.
wgtmac
reviewed
Oct 19, 2023
| page_buffer->data() + levels_byte_len, | ||
| uncompressed_len - levels_byte_len, | ||
| decompression_buffer_->mutable_data() + levels_byte_len)); | ||
| if (decompressed_len != uncompressed_len - levels_byte_len) { |
There was a problem hiding this comment.
The requirement is that uncompressed_len from the page header is something that we can always trust.
There was a problem hiding this comment.
I've seen the arrow-rs implemention, it check the size here. The main problem is that the size is not exact, the decoder will have bad tail buffer, like getting 0 in that multi-gzip file.
pitrou
approved these changes
Oct 19, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4712dab. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…as size in page header (apache#38327) ### Rationale for this change As mentioned in issue, currently we only decompress the page without checking the decompress size. This patch add a checkings. ### What changes are included in this PR? Throw exception when size not matches in `SerializedPageReader::DecompressIfNeeded` ### Are these changes tested? Yes. ### Are there any user-facing changes? Non-conforming files may throw an exception while they would silently return invalid results before. * Closes: apache#38326 Authored-by: mwish <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…as size in page header (apache#38327) ### Rationale for this change As mentioned in issue, currently we only decompress the page without checking the decompress size. This patch add a checkings. ### What changes are included in this PR? Throw exception when size not matches in `SerializedPageReader::DecompressIfNeeded` ### Are these changes tested? Yes. ### Are there any user-facing changes? Non-conforming files may throw an exception while they would silently return invalid results before. * Closes: apache#38326 Authored-by: mwish <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…as size in page header (apache#38327) ### Rationale for this change As mentioned in issue, currently we only decompress the page without checking the decompress size. This patch add a checkings. ### What changes are included in this PR? Throw exception when size not matches in `SerializedPageReader::DecompressIfNeeded` ### Are these changes tested? Yes. ### Are there any user-facing changes? Non-conforming files may throw an exception while they would silently return invalid results before. * Closes: apache#38326 Authored-by: mwish <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As mentioned in issue, currently we only decompress the page without checking the decompress size.
This patch add a checkings.
What changes are included in this PR?
Throw exception when size not matches in
SerializedPageReader::DecompressIfNeededAre these changes tested?
Yes.
Are there any user-facing changes?
Non-conforming files may throw an exception while they would silently return invalid results before.