GH-38282: [C++] Implement ReplaceString with the right type signature #38283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit test-build-vcpkg-win |
|
Revision: bae2dfb Submitted crossbow builds: ursacomputing/crossbow @ actions-f2e7b19e86
|
raulcd
reviewed
Oct 16, 2023
github-actions
bot
added
awaiting changes
felipecrv
force-pushed
the
fix_string_view
branch
from
bae2dfb
to
b90e280
Compare
github-actions
bot
added
awaiting change review
|
@raulcd Why are you assigning this to me? Do you want me to review it? |
|
oh! sorry, @pitrou I meant to add you as reviewer not assign it to you |
pitrou
approved these changes
Oct 16, 2023
raulcd
added
awaiting merge
raulcd
pushed a commit
that referenced
this pull request
Oct 16, 2023
…#38283) ### Rationale for this change The type signature of `ReplaceString` should be identical when arrow is compiled with or without `ARROW_WITH_RE2`. ### What changes are included in this PR? The right signature + delegating to the implementation that takes `re2::StringPiece`. The conversion should be a no-op when compiled and optimized. ### Are these changes tested? By existing tests and CI checks. * Closes: #38282 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6b118bb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…nature (apache#38283) ### Rationale for this change The type signature of `ReplaceString` should be identical when arrow is compiled with or without `ARROW_WITH_RE2`. ### What changes are included in this PR? The right signature + delegating to the implementation that takes `re2::StringPiece`. The conversion should be a no-op when compiled and optimized. ### Are these changes tested? By existing tests and CI checks. * Closes: apache#38282 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
felipecrv
changed the title
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…nature (apache#38283) ### Rationale for this change The type signature of `ReplaceString` should be identical when arrow is compiled with or without `ARROW_WITH_RE2`. ### What changes are included in this PR? The right signature + delegating to the implementation that takes `re2::StringPiece`. The conversion should be a no-op when compiled and optimized. ### Are these changes tested? By existing tests and CI checks. * Closes: apache#38282 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…nature (apache#38283) ### Rationale for this change The type signature of `ReplaceString` should be identical when arrow is compiled with or without `ARROW_WITH_RE2`. ### What changes are included in this PR? The right signature + delegating to the implementation that takes `re2::StringPiece`. The conversion should be a no-op when compiled and optimized. ### Are these changes tested? By existing tests and CI checks. * Closes: apache#38282 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The type signature of
ReplaceStringshould be identical when arrow is compiled with or withoutARROW_WITH_RE2.What changes are included in this PR?
The right signature + delegating to the implementation that takes
re2::StringPiece. The conversion should be a no-op when compiled and optimized.Are these changes tested?
By existing tests and CI checks.