Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35369: [Docs] Fix reST markup around ref:IPC format <format-ipc> #38276

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

Divyansh200102
Copy link
Contributor

@Divyansh200102 Divyansh200102 commented Oct 15, 2023

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kou
Copy link
Member

kou commented Oct 16, 2023

Could you read the auto-generated comment?
#38276 (comment)

And could you read our pull request template and follow it instead of remove it entirely without reading it?

@Divyansh200102 Divyansh200102 changed the title fix reStructuredText link markup GH-35369:[Docs] updated :ref:IPC format <format-ipc>' instead of ref:IPC <format-ipc>` Oct 16, 2023
@Divyansh200102 Divyansh200102 changed the title GH-35369:[Docs] updated :ref:IPC format <format-ipc>' instead of ref:IPC <format-ipc>` GH-35369:[Docs] updated ref:IPC <format-ipc> to ref:`IPC format <format-ipc>' Oct 16, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check your change on local?
See also: https://arrow.apache.org/docs/developers/documentation.html#building-with-docker

I think that the following is the needed change:

diff --git a/docs/source/format/Glossary.rst b/docs/source/format/Glossary.rst
index 65d6e0afa..d0adc0cc3 100644
--- a/docs/source/format/Glossary.rst
+++ b/docs/source/format/Glossary.rst
@@ -174,7 +174,7 @@ Glossary
        .. seealso:: :term:`data type`
 
    record batch
-       **In the :ref:`IPC format <format-ipc>`**: the primitive unit
+       **In the :ref:`IPC format <format-ipc>` **: the primitive unit
        of data.  A record batch consists of an ordered list of
        :term:`buffers <buffer>` corresponding to a :term:`schema`.
 

@@ -82,7 +82,7 @@ and computation functions, possibly incremental.
structure as described in text above.

Record batches can be sent between implementations, such as via
:ref:`IPC <format-ipc>` or
:ref:`IPC format <format-ipc>` or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?
https://arrow.apache.org/docs/cpp/tables.html#record-batches renders correctly without this:

Record batches can be sent between implementations, such as via IPC or via ...

@@ -184,7 +184,7 @@ implementation can support:
same endianness). This includes ancillary functionality such as reading
and writing various file formats, such as Parquet.
2. Cross endian support (implementations will do byte reordering when
appropriate for :ref:`IPC <format-ipc>` and :ref:`Flight <flight-rpc>`
appropriate for :ref:`IPC format <format-ipc>` and :ref:`Flight <flight-rpc>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

https://arrow.apache.org/docs/developers/overview.html#endianness

(implementations will do byte reordering when appropriate for IPC and...

@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:

Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC format <format-ipc>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot

(a representation of a RecordBatch IPC message)

@kou kou changed the title GH-35369:[Docs] updated ref:IPC <format-ipc> to ref:`IPC format <format-ipc>' GH-35369: [Docs] updated ref:IPC <format-ipc> to ref:`IPC format <format-ipc>' Oct 18, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 18, 2023
@Divyansh200102
Copy link
Contributor Author

Divyansh200102 commented Oct 18, 2023

hi, @kou i am trying to setup the project locally using the docker-compose.yml file by using the command "docker compose up -d" but this is error is showing up (Error response from daemon: manifest for amd64/maven:3.5.4-eclipse-temurin-8 not found: manifest unknown: manifest unknown) i think this version of amd64/maven is not in the registry .i tried pulling manually as well but still nothing can you help me out to solve this?i checked docker hub as well but this version of amd64/maven is not there.

@raulcd
Copy link
Member

raulcd commented Oct 18, 2023

Hi @Divyansh200102 we use docker-compose as a utility to help us run different testing containers mainly for CI and some locally but we don't use docker-compose up as we have lots of images and this is not supposed to work.
Due to the large amount of languages and tools in the Apache Arrow repository we have in this contribution guide several examples on how to build and test locally for the different languages. Please take a look there and don't hesitate on asking if something is not clear enough: https://arrow.apache.org/docs/dev/developers/guide/index.html

@raulcd
Copy link
Member

raulcd commented Oct 18, 2023

BTW if you are trying to build the documentation locally here is the documentation: https://arrow.apache.org/docs/developers/documentation.html

@Divyansh200102
Copy link
Contributor Author

Divyansh200102 commented Oct 19, 2023

i am encountering this @raulcd
https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f
i ran {pip install -e "dev/archery[all]"} this command to install the archery and after that ran the docker command {archery docker run -v "${PWD}/docs:/build/docs" ubuntu-docs} but it's throwing error
archery is built but i am not able to run the docker command even though the archery is built still it's saying that archery command is not recognised .

@raulcd
Copy link
Member

raulcd commented Oct 19, 2023

Hi @Divyansh200102 , it seems to be failing on building pygit2 which is a dependency for Archery:

Failed to build pygit2
ERROR: Could not build wheels for pygit2, which is required to install pyproject.toml-based projects

I am not entirely sure what the problem is with the logs provided but you are probably using Python 3.12 and that's why there are no wheels available yet for them as seen on PyPI: https://pypi.org/project/pygit2/#files
If you want to build from source you'll need to follow their installation guide requirements for Windows: https://www.pygit2.org/install.html#installing-on-windows

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 24, 2023
@Divyansh200102
Copy link
Contributor Author

Please review the changes @kou

@kou kou changed the title GH-35369: [Docs] updated ref:IPC <format-ipc> to ref:`IPC format <format-ipc>' GH-35369: [Docs] updated ref:IPC <format-ipc> to ref:IPC format <format-ipc> Jan 20, 2024
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:

Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we don't need this:

https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot

ArrowRecordBatch (a representation of a RecordBatch IPC message).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @kou

@kou kou changed the title GH-35369: [Docs] updated ref:IPC <format-ipc> to ref:IPC format <format-ipc> GH-35369: [Docs] Update ref:IPC <format-ipc> to ref:IPC format <format-ipc> Jan 20, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 20, 2024
@kou kou changed the title GH-35369: [Docs] Update ref:IPC <format-ipc> to ref:IPC format <format-ipc> GH-35369: [Docs] Add a missing space after ref:IPC format <format-ipc> Jan 20, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 20, 2024
@kou
Copy link
Member

kou commented Jan 20, 2024

@github-actions crossbow submit preview-docs

Copy link

Revision: b934b66

Submitted crossbow builds: ursacomputing/crossbow @ actions-3dedf8ca9e

Task Status
preview-docs GitHub Actions

@kou
Copy link
Member

kou commented Jan 21, 2024

Hmm. The "IPC format" link markup is solved but the ** ... ** mark is broken...

http://crossbow.voltrondata.com/pr_docs/38276/format/Glossary.html#term-record-batch

**In the IPC format **: the primitive unit of data.

@kou
Copy link
Member

kou commented Jan 21, 2024

@AlenkaF Could you help us for reST markup?

@AlenkaF
Copy link
Member

AlenkaF commented Jan 22, 2024

@github-actions crossbow submit preview-docs

Copy link

Revision: 8d294b7

Submitted crossbow builds: ursacomputing/crossbow @ actions-b2a30f86b0

Task Status
preview-docs GitHub Actions

@AlenkaF
Copy link
Member

AlenkaF commented Jan 22, 2024

@github-actions crossbow submit preview-docs

Copy link

Revision: 37e8fdc

Submitted crossbow builds: ursacomputing/crossbow @ actions-04924a384c

Task Status
preview-docs GitHub Actions

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlenkaF AlenkaF merged commit 315e06a into apache:main Jan 22, 2024
7 checks passed
@AlenkaF AlenkaF removed the awaiting change review Awaiting change review label Jan 22, 2024
@kou kou changed the title GH-35369: [Docs] Add a missing space after ref:IPC format <format-ipc> GH-35369: [Docs] Fix reST markup around ref:IPC format <format-ipc> Jan 22, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 315e06a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@Divyansh200102 Divyansh200102 deleted the fix-reStructuredText-link-markup branch January 23, 2024 03:34
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…mat-ipc>` (apache#38276)

* Closes: apache#35369

Lead-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…mat-ipc>` (apache#38276)

* Closes: apache#35369

Lead-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…mat-ipc>` (apache#38276)

* Closes: apache#35369

Lead-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Divyansh200102 <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] reStructuredText link markup is broken
4 participants