-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35369: [Docs] Fix reST markup around ref:IPC format <format-ipc>
#38276
GH-35369: [Docs] Fix reST markup around ref:IPC format <format-ipc>
#38276
Conversation
Divyansh200102
commented
Oct 15, 2023
•
edited
Loading
edited
- Closes: [Docs] reStructuredText link markup is broken #35369
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
Could you read the auto-generated comment? And could you read our pull request template and follow it instead of remove it entirely without reading it? |
IPC format <format-ipc>' instead of ref:
IPC <format-ipc>`
IPC format <format-ipc>' instead of ref:
IPC <format-ipc>` IPC <format-ipc>
to ref:`IPC format <format-ipc>'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check your change on local?
See also: https://arrow.apache.org/docs/developers/documentation.html#building-with-docker
I think that the following is the needed change:
diff --git a/docs/source/format/Glossary.rst b/docs/source/format/Glossary.rst
index 65d6e0afa..d0adc0cc3 100644
--- a/docs/source/format/Glossary.rst
+++ b/docs/source/format/Glossary.rst
@@ -174,7 +174,7 @@ Glossary
.. seealso:: :term:`data type`
record batch
- **In the :ref:`IPC format <format-ipc>`**: the primitive unit
+ **In the :ref:`IPC format <format-ipc>` **: the primitive unit
of data. A record batch consists of an ordered list of
:term:`buffers <buffer>` corresponding to a :term:`schema`.
docs/source/cpp/tables.rst
Outdated
@@ -82,7 +82,7 @@ and computation functions, possibly incremental. | |||
structure as described in text above. | |||
|
|||
Record batches can be sent between implementations, such as via | |||
:ref:`IPC <format-ipc>` or | |||
:ref:`IPC format <format-ipc>` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
https://arrow.apache.org/docs/cpp/tables.html#record-batches renders correctly without this:
Record batches can be sent between implementations, such as via IPC or via ...
docs/source/developers/overview.rst
Outdated
@@ -184,7 +184,7 @@ implementation can support: | |||
same endianness). This includes ancillary functionality such as reading | |||
and writing various file formats, such as Parquet. | |||
2. Cross endian support (implementations will do byte reordering when | |||
appropriate for :ref:`IPC <format-ipc>` and :ref:`Flight <flight-rpc>` | |||
appropriate for :ref:`IPC format <format-ipc>` and :ref:`Flight <flight-rpc>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
https://arrow.apache.org/docs/developers/overview.html#endianness
(implementations will do byte reordering when appropriate for IPC and...
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot: | |||
|
|||
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_ | |||
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and | |||
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>` | |||
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC format <format-ipc>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
(a representation of a RecordBatch IPC message)
IPC <format-ipc>
to ref:`IPC format <format-ipc>'IPC <format-ipc>
to ref:`IPC format <format-ipc>'
hi, @kou i am trying to setup the project locally using the docker-compose.yml file by using the command "docker compose up -d" but this is error is showing up (Error response from daemon: manifest for amd64/maven:3.5.4-eclipse-temurin-8 not found: manifest unknown: manifest unknown) i think this version of amd64/maven is not in the registry .i tried pulling manually as well but still nothing can you help me out to solve this?i checked docker hub as well but this version of amd64/maven is not there. |
Hi @Divyansh200102 we use docker-compose as a utility to help us run different testing containers mainly for CI and some locally but we don't use |
BTW if you are trying to build the documentation locally here is the documentation: https://arrow.apache.org/docs/developers/documentation.html |
i am encountering this @raulcd |
Hi @Divyansh200102 , it seems to be failing on building pygit2 which is a dependency for Archery:
I am not entirely sure what the problem is with the logs provided but you are probably using Python 3.12 and that's why there are no wheels available yet for them as seen on PyPI: https://pypi.org/project/pygit2/#files |
Please review the changes @kou |
IPC <format-ipc>
to ref:`IPC format <format-ipc>'IPC <format-ipc>
to ref:IPC format <format-ipc>
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot: | |||
|
|||
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_ | |||
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and | |||
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>` | |||
`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we don't need this:
https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
ArrowRecordBatch (a representation of a RecordBatch IPC message).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @kou
IPC <format-ipc>
to ref:IPC format <format-ipc>
IPC <format-ipc>
to ref:IPC format <format-ipc>
IPC <format-ipc>
to ref:IPC format <format-ipc>
IPC format <format-ipc>
@github-actions crossbow submit preview-docs |
Revision: b934b66 Submitted crossbow builds: ursacomputing/crossbow @ actions-3dedf8ca9e
|
Hmm. The "IPC format" link markup is solved but the http://crossbow.voltrondata.com/pr_docs/38276/format/Glossary.html#term-record-batch
|
@AlenkaF Could you help us for reST markup? |
Co-authored-by: Alenka Frim <[email protected]>
@github-actions crossbow submit preview-docs |
Revision: 8d294b7 Submitted crossbow builds: ursacomputing/crossbow @ actions-b2a30f86b0
|
@github-actions crossbow submit preview-docs |
Revision: 37e8fdc Submitted crossbow builds: ursacomputing/crossbow @ actions-04924a384c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPC format <format-ipc>
IPC format <format-ipc>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 315e06a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…mat-ipc>` (apache#38276) * Closes: apache#35369 Lead-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…mat-ipc>` (apache#38276) * Closes: apache#35369 Lead-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…mat-ipc>` (apache#38276) * Closes: apache#35369 Lead-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Divyansh200102 <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Signed-off-by: AlenkaF <[email protected]>