-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38239: [CI][Python] Disable -W error on Python CI jobs temporarily #38238
GH-38239: [CI][Python] Disable -W error on Python CI jobs temporarily #38238
Conversation
jorisvandenbossche
commented
Oct 12, 2023
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- Closes: [CI][Python] test-conda-python is failing due to new DeprecationWarning raised on aiohttp #38239
@github-actions crossbow submit test-conda-python-3.11 |
|
Revision: d20f7c9 Submitted crossbow builds: ursacomputing/crossbow @ actions-8e5c6e6b8b
|
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 7b8e9db Submitted crossbow builds: ursacomputing/crossbow @ actions-ecf19f5340
|
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 78460fa Submitted crossbow builds: ursacomputing/crossbow @ actions-77ba2e9d8a
|
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 4b07aca Submitted crossbow builds: ursacomputing/crossbow @ actions-e7fc135add
|
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 33c672a Submitted crossbow builds: ursacomputing/crossbow @ actions-c9b7a68d6e
|
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 33c672a Submitted crossbow builds: ursacomputing/crossbow @ actions-055887eb3e
|
It would be nice to disable all |
@github-actions crossbow submit test-conda-python-3.11 |
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 3115ea6 Submitted crossbow builds: ursacomputing/crossbow @ actions-3f3cee7e54
|
And also locally that fails:
So indeed it seems to be something with passing it as an env var as Jakob mentions, and how spaces/quotes get treated in that case .. |
It works if there are no spaces in the argument to
But, the problem is that this could be a bit generic, ignoring also other warnings. It's maybe good enough for now, though. |
This works:
|
That gives me (the tests then do run, so that might mask the error) |
@github-actions crossbow submit test-conda-python-3.11 |
Revision: d278376 Submitted crossbow builds: ursacomputing/crossbow @ actions-4cb298fb5a
|
This reverts commit d278376.
It is green but the whole
|
Yep, that's what I said above ;) I see that locally as well, and then the tests are green, because also the |
@github-actions crossbow submit test-conda-python-3.11 |
Revision: 148d5b2 Submitted crossbow builds: ursacomputing/crossbow @ actions-5b81a9c311
|
@jorisvandenbossche I agree with your statement here: #38259 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…#38238) * Closes: #38239 Lead-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f325ce9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…rarily (apache#38238) * Closes: apache#38239 Lead-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…rarily (apache#38238) * Closes: apache#38239 Lead-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…rarily (apache#38238) * Closes: apache#38239 Lead-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>