Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38239: [CI][Python] Disable -W error on Python CI jobs temporarily #38238

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Oct 12, 2023

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 12, 2023
@jorisvandenbossche jorisvandenbossche changed the title [CI] Ignore deprecation warning from aiohttp GH-38239: [CI] Ignore deprecation warning from aiohttp Oct 12, 2023
@github-actions
Copy link

⚠️ GitHub issue #38239 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

Revision: d20f7c9

Submitted crossbow builds: ursacomputing/crossbow @ actions-8e5c6e6b8b

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 7b8e9db

Submitted crossbow builds: ursacomputing/crossbow @ actions-ecf19f5340

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 78460fa

Submitted crossbow builds: ursacomputing/crossbow @ actions-77ba2e9d8a

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 4b07aca

Submitted crossbow builds: ursacomputing/crossbow @ actions-e7fc135add

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 33c672a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9b7a68d6e

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 33c672a

Submitted crossbow builds: ursacomputing/crossbow @ actions-055887eb3e

Task Status
test-conda-python-3.11 Github Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 12, 2023
@danepitkin
Copy link
Member

It would be nice to disable all DeprecationWarnings and FutureWarnings since they pop up a lot in our dependencies 😬 I hadn't anticipated that when enabling initially.

@assignUser
Copy link
Member

@github-actions crossbow submit test-conda-python-3.11

@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 3115ea6

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f3cee7e54

Task Status
test-conda-python-3.11 Github Actions

@jorisvandenbossche
Copy link
Member Author

@raulcd I am afraid that will fail, that was the first thing I tried as well .. 78460fa

@jorisvandenbossche
Copy link
Member Author

And also locally that fails:

$ export PYTEST_ARGS="-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'"
$ PYTHONASYNCIODEBUG=1 pytest python/pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec $PYTEST_ARGS
ERROR: while parsing the following warning configuration:

  'ignore:Setting

This error occurred:

invalid action: "'ignore"

So indeed it seems to be something with passing it as an env var as Jakob mentions, and how spaces/quotes get treated in that case ..

@jorisvandenbossche
Copy link
Member Author

It works if there are no spaces in the argument to -W and so not needing the quotes:

export PYTEST_ARGS="-W error -W ignore:Setting:DeprecationWarning"

But, the problem is that this could be a bit generic, ignoring also other warnings. It's maybe good enough for now, though.

@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

This works:

export PYTEST_ARGS="-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'"
pytest -r s $(PYTEST_ARGS)

@jorisvandenbossche
Copy link
Member Author

That gives me PYTEST_ARGS: command not found, but that might depend on the bash terminal I am using?

(the tests then do run, so that might mask the error)

@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: d278376

Submitted crossbow builds: ursacomputing/crossbow @ actions-4cb298fb5a

Task Status
test-conda-python-3.11 Github Actions

@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

It is green but the whole PYTEST_ARGS were ignored:

 PYTEST_ARGS: command not found

@jorisvandenbossche
Copy link
Member Author

Yep, that's what I said above ;) I see that locally as well, and then the tests are green, because also the -W error (which is causing the error) wasn't actually passed.

@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

@github-actions crossbow submit test-conda-python-3.11

@github-actions
Copy link

Revision: 148d5b2

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b81a9c311

Task Status
test-conda-python-3.11 Github Actions

@raulcd raulcd changed the title GH-38239: [CI] Ignore deprecation warning from aiohttp GH-38239: [CI][Python] Disable -W error on Python CI jobs temporarily Oct 13, 2023
@raulcd
Copy link
Member

raulcd commented Oct 13, 2023

@jorisvandenbossche I agree with your statement here: #38259 (comment)
I've removed the -W error and created a follow up issue here: #38262

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raulcd raulcd merged commit f325ce9 into apache:main Oct 16, 2023
13 checks passed
@raulcd raulcd removed the awaiting change review Awaiting change review label Oct 16, 2023
raulcd added a commit that referenced this pull request Oct 16, 2023
…#38238)

* Closes: #38239

Lead-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 16, 2023
@jorisvandenbossche jorisvandenbossche deleted the pytest-warning-error-aiohttp branch October 17, 2023 06:42
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f325ce9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
…rarily (apache#38238)

* Closes: apache#38239

Lead-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…rarily (apache#38238)

* Closes: apache#38239

Lead-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…rarily (apache#38238)

* Closes: apache#38239

Lead-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Python] test-conda-python is failing due to new DeprecationWarning raised on aiohttp
4 participants