-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38197: [R] Update actions that used setup-r@v1 to use setup-r@v2 #38218
Conversation
|
@github-actions crossbow submit test-r-devdocs test-r-linux-rchk |
|
@github-actions crossbow submit test-r-devdocs test-r-linux-rchk |
Revision: e0c3e30 Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7ee2d52c
|
@github-actions crossbow submit test-r-devdocs test-r-linux-rchk |
Revision: 7522af7 Submitted crossbow builds: ursacomputing/crossbow @ actions-f75909d651
|
@github-actions crossbow submit test-r-devdocs test-r-linux-rchk |
Revision: c98384f Submitted crossbow builds: ursacomputing/crossbow @ actions-32137a2a94
|
@assignUser could you give this a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…r@v2 (apache#38218) ### Rationale for this change CI jobs that used setup-r@ v1 no longer run without error. ### What changes are included in this PR? - Updated the rchk job to use the `setup-r@ v2` - Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time. ### Are these changes tested? Will be covered by crossbow jobs submitted below. ### Are there any user-facing changes? No. * Closes: apache#38197 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
…38218) ### Rationale for this change CI jobs that used setup-r@ v1 no longer run without error. ### What changes are included in this PR? - Updated the rchk job to use the `setup-r@ v2` - Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time. ### Are these changes tested? Will be covered by crossbow jobs submitted below. ### Are there any user-facing changes? No. * Closes: #38197 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0640f94. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…r@v2 (apache#38218) ### Rationale for this change CI jobs that used setup-r@ v1 no longer run without error. ### What changes are included in this PR? - Updated the rchk job to use the `setup-r@ v2` - Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time. ### Are these changes tested? Will be covered by crossbow jobs submitted below. ### Are there any user-facing changes? No. * Closes: apache#38197 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
…r@v2 (apache#38218) ### Rationale for this change CI jobs that used setup-r@ v1 no longer run without error. ### What changes are included in this PR? - Updated the rchk job to use the `setup-r@ v2` - Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time. ### Are these changes tested? Will be covered by crossbow jobs submitted below. ### Are there any user-facing changes? No. * Closes: apache#38197 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
…r@v2 (apache#38218) ### Rationale for this change CI jobs that used setup-r@ v1 no longer run without error. ### What changes are included in this PR? - Updated the rchk job to use the `setup-r@ v2` - Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time. ### Are these changes tested? Will be covered by crossbow jobs submitted below. ### Are there any user-facing changes? No. * Closes: apache#38197 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
Rationale for this change
CI jobs that used setup-r@v1 no longer run without error.
What changes are included in this PR?
setup-r@v2
setup-r@v2
. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.Are these changes tested?
Will be covered by crossbow jobs submitted below.
Are there any user-facing changes?
No.