Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38197: [R] Update actions that used setup-r@v1 to use setup-r@v2 #38218

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Oct 11, 2023

Rationale for this change

CI jobs that used setup-r@v1 no longer run without error.

What changes are included in this PR?

  • Updated the rchk job to use the setup-r@v2
  • Updated the devdocs job to use setup-r@v2. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

Are these changes tested?

Will be covered by crossbow jobs submitted below.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #38197 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 11, 2023
@paleolimbot paleolimbot marked this pull request as draft October 11, 2023 19:25
@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs test-r-linux-rchk

@github-actions
Copy link

Unable to match any tasks for `test-r-devdocs`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6487289740

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs test-r-linux-rchk

@github-actions
Copy link

Revision: e0c3e30

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7ee2d52c

Task Status
test-r-devdocs Github Actions
test-r-linux-rchk Github Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs test-r-linux-rchk

@github-actions
Copy link

Revision: 7522af7

Submitted crossbow builds: ursacomputing/crossbow @ actions-f75909d651

Task Status
test-r-devdocs Github Actions
test-r-linux-rchk Github Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs test-r-linux-rchk

@github-actions
Copy link

Revision: c98384f

Submitted crossbow builds: ursacomputing/crossbow @ actions-32137a2a94

Task Status
test-r-devdocs Github Actions
test-r-linux-rchk Github Actions

@paleolimbot paleolimbot marked this pull request as ready for review October 12, 2023 00:38
@paleolimbot
Copy link
Member Author

@assignUser could you give this a quick look?

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paleolimbot paleolimbot merged commit 0640f94 into apache:main Oct 12, 2023
8 checks passed
@paleolimbot paleolimbot removed the awaiting committer review Awaiting committer review label Oct 12, 2023
llama90 pushed a commit to llama90/arrow that referenced this pull request Oct 12, 2023
…r@v2 (apache#38218)

### Rationale for this change

CI jobs that used setup-r@ v1 no longer run without error.

### What changes are included in this PR?

- Updated the rchk job to use the `setup-r@ v2`
- Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

### Are these changes tested?

Will be covered by crossbow jobs submitted below.

### Are there any user-facing changes?

No.
* Closes: apache#38197

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
raulcd pushed a commit that referenced this pull request Oct 13, 2023
…38218)

### Rationale for this change

CI jobs that used setup-r@ v1 no longer run without error.

### What changes are included in this PR?

- Updated the rchk job to use the `setup-r@ v2`
- Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

### Are these changes tested?

Will be covered by crossbow jobs submitted below.

### Are there any user-facing changes?

No.
* Closes: #38197

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0640f94.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
…r@v2 (apache#38218)

### Rationale for this change

CI jobs that used setup-r@ v1 no longer run without error.

### What changes are included in this PR?

- Updated the rchk job to use the `setup-r@ v2`
- Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

### Are these changes tested?

Will be covered by crossbow jobs submitted below.

### Are there any user-facing changes?

No.
* Closes: apache#38197

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…r@v2 (apache#38218)

### Rationale for this change

CI jobs that used setup-r@ v1 no longer run without error.

### What changes are included in this PR?

- Updated the rchk job to use the `setup-r@ v2`
- Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

### Are these changes tested?

Will be covered by crossbow jobs submitted below.

### Are there any user-facing changes?

No.
* Closes: apache#38197

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…r@v2 (apache#38218)

### Rationale for this change

CI jobs that used setup-r@ v1 no longer run without error.

### What changes are included in this PR?

- Updated the rchk job to use the `setup-r@ v2`
- Updated the devdocs job to use `setup-r@ v2`. To make this work, we needed to remove the Windows build because it was installing an old version of R. It seems that the job has been running an outdated and unsable (for most users) for a very long time.

### Are these changes tested?

Will be covered by crossbow jobs submitted below.

### Are there any user-facing changes?

No.
* Closes: apache#38197

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R][CI] test-r-devdocs and test-r-linux-rchk fail to set up R 4.1.3
2 participants