-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38201: [CI][Packaging] Pin zlib 1.2.13 when using thrift on conan #38202
Conversation
@github-actions crossbow submit conan-maximum |
|
Revision: a174afc Submitted crossbow builds: ursacomputing/crossbow @ actions-dbb832daad
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds logical, thanks!
…38202) ### Rationale for this change There is a conflict between the required Zlib version when using both thrift and GRPC. ### What changes are included in this PR? Pinning zlib when using thrifht. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: #38201 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
In general, we should not add our workaround to only our copy as much as possible. Instead, we should fix a problem in upstream and our side as much as possible. In this case, it seems that there is a fix in upstream: conan-io/conan-center-index#19803 |
…conan (apache#38202) ### Rationale for this change There is a conflict between the required Zlib version when using both thrift and GRPC. ### What changes are included in this PR? Pinning zlib when using thrifht. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#38201 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 757cf3e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…conan (apache#38202) ### Rationale for this change There is a conflict between the required Zlib version when using both thrift and GRPC. ### What changes are included in this PR? Pinning zlib when using thrifht. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#38201 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…conan (apache#38202) ### Rationale for this change There is a conflict between the required Zlib version when using both thrift and GRPC. ### What changes are included in this PR? Pinning zlib when using thrifht. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#38201 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…conan (apache#38202) ### Rationale for this change There is a conflict between the required Zlib version when using both thrift and GRPC. ### What changes are included in this PR? Pinning zlib when using thrifht. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#38201 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Rationale for this change
There is a conflict between the required Zlib version when using both thrift and GRPC.
What changes are included in this PR?
Pinning zlib when using thrifht.
Are these changes tested?
Via archery
Are there any user-facing changes?
No