Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python] Add docs for missing type checking functions #38119

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Oct 7, 2023

Rationale for this change

These appear to be missing and I only found them by accident!

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@judahrand judahrand changed the title MINOR: [PYTHON] Add docs for missing type checking functions MINOR: [Python] Add docs for missing type checking functions Oct 7, 2023
@AlenkaF
Copy link
Member

AlenkaF commented Oct 23, 2023

Thanks @judahrand !

I am a bit confused with is_run_end_encoded entry. The CI doesn't complain and the diff from this PR doesn't show but when I look at the dev docs I can see the is_run_end_encoded already present after is_nested:
https://github.com/apache/arrow/blob/main/docs/source/python/api/datatypes.rst#type-checking

Could we therefore remove is_run_end_encoded and also add is_fixed_size_list() and is_duration() - I think they are also missing from the list.

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 24, 2023
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlenkaF AlenkaF merged commit 5b9f4b9 into apache:main Oct 24, 2023
8 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Oct 24, 2023
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 24, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5b9f4b9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 25, 2023
…38119)

### Rationale for this change

These appear to be missing and I only found them by accident! 

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

Authored-by: Judah Rand <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…38119)

### Rationale for this change

These appear to be missing and I only found them by accident! 

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

Authored-by: Judah Rand <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…38119)

### Rationale for this change

These appear to be missing and I only found them by accident! 

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

Authored-by: Judah Rand <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants