-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Python] Add docs for missing type checking functions #38119
Conversation
Thanks @judahrand ! I am a bit confused with Could we therefore remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5b9f4b9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…38119) ### Rationale for this change These appear to be missing and I only found them by accident! ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? Authored-by: Judah Rand <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…38119) ### Rationale for this change These appear to be missing and I only found them by accident! ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? Authored-by: Judah Rand <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…38119) ### Rationale for this change These appear to be missing and I only found them by accident! ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? Authored-by: Judah Rand <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Rationale for this change
These appear to be missing and I only found them by accident!
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?