Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38117: [C++][Parquet] Change DictEncoder dtor checking to warning log #38118

Merged
merged 3 commits into from
Oct 19, 2023
Merged

GH-38117: [C++][Parquet] Change DictEncoder dtor checking to warning log #38118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b77ec6
Parquet: tiny fix DCHECK in dictionary
mapleFU Oct 7, 2023
a84387b
Merge branch 'main' into minor/parquet-dict-encoder-dtor-warning
mapleFU Oct 19, 2023
5d76b89
remove dtor for DictEncoderImpl
mapleFU Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/parquet/encoding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public DictEncoder<DType> {
dict_encoded_size_(0),
memo_table_(pool, kInitialHashTableSize) {}

~DictEncoderImpl() override { DCHECK(buffered_indices_.empty()); }
~DictEncoderImpl() = default;

int dict_encoded_size() const override { return dict_encoded_size_; }

Expand Down
Loading