GH-38079: [R] Allow override of version used to download libarrow static library #38080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
paleolimbot
changed the title
|
|
|
Tested on MacOS 10.13 using Build log: ...and we get the package built with S3: |
|
Tested on Windows, too. The easiest way to get it there is to |
paleolimbot
force-pushed
the
version-override
branch
from
e74215e
to
2de3d43
Compare
|
@assignUser is this fix worth merging? I do need this or something like it to debug the Windows issues we've been seeing. An alternative would be to go straight for |
|
I like the idea but this will cause conflicts with #38115 but as that is done (imo) I will start on the 'get latest nightly binary'-feature now were I can integrate this. For your local test we do have |
assignUser
pushed a commit
that referenced
this pull request
Oct 9, 2023
### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., #38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: #38088 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
|
Got it! I will rework this once there's a pre-calculatable URL for "the last one". I like URL better than a local file (because URL can be either) but the right way to do that would be to replace the existing "local file" option and unify it under "libarrow zip url". |
|
Closing as #38236 is close to completion! |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#38089) ### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., apache#38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: apache#38088 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38089) ### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., apache#38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: apache#38088 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38089) ### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., apache#38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: apache#38088 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Doing a bundled build of libarrow is time-consuming and makes casual contribution difficult. Downloading a recent nightly static library is sufficient in most cases; however, there is no route to override the version used to do this download.
What changes are included in this PR?
Adds an environment variable
LIBARROW_BINARY_VERSIONthat can be used to override theVERSIONfor the purposes of downloading the binary.Are these changes tested?
Not yet! Working on the best way to do this.
Are there any user-facing changes?
No (this is currently just a developer-facing tool).