-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38057: [Python][CI] Fix flaky hypothesis tests #38058
Conversation
|
@github-actions crossbow submit test-conda-python-3.11-hypothesis |
Revision: 9b6e1d5 Submitted crossbow builds: ursacomputing/crossbow @ actions-6d93c05afe
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bcbc707. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests. ### What changes are included in this PR? * Suppress hypothesis warnings for test data generation being too slow (> 2 seconds). ### Are these changes tested? Will test the hypothesis CI job here. ### Are there any user-facing changes? No * Closes: apache#38057 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests. ### What changes are included in this PR? * Suppress hypothesis warnings for test data generation being too slow (> 2 seconds). ### Are these changes tested? Will test the hypothesis CI job here. ### Are there any user-facing changes? No * Closes: apache#38057 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests. ### What changes are included in this PR? * Suppress hypothesis warnings for test data generation being too slow (> 2 seconds). ### Are these changes tested? Will test the hypothesis CI job here. ### Are there any user-facing changes? No * Closes: apache#38057 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.
What changes are included in this PR?
Are these changes tested?
Will test the hypothesis CI job here.
Are there any user-facing changes?
No