Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38057: [Python][CI] Fix flaky hypothesis tests #38058

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Oct 5, 2023

Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

What changes are included in this PR?

  • Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

Are these changes tested?

Will test the hypothesis CI job here.

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

⚠️ GitHub issue #38057 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions github-actions bot added the awaiting review Awaiting review label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Revision: 9b6e1d5

Submitted crossbow builds: ursacomputing/crossbow @ actions-6d93c05afe

Task Status
test-conda-python-3.11-hypothesis Github Actions

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 5, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit bcbc707 into apache:main Oct 6, 2023
13 checks passed
@kou kou removed the awaiting merge Awaiting merge label Oct 6, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bcbc707.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][CI] Fix flaky hypothesis tests
3 participants