GH-37799: [C++] Compute: CommonTemporal support time32 and time64 casting #37949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mapleFU
commented
Sep 29, 2023
github-actions
bot
added
awaiting committer review
|
@bkietz I've do a basic impl, would you mind take a look? |
github-actions
bot
added
awaiting changes
bkietz
requested changes
Sep 29, 2023
github-actions
bot
added
awaiting change review
|
@bkietz I've resolve the comments now |
bkietz
approved these changes
Oct 2, 2023
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 22df70a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…64 casting (apache#37949) ### Rationale for this change The original problem in mentioned in apache#37799 1. `SECOND` in Parquet would always cast to `MILLS` 2. `eq` not support `eq(time32[s], time32[ms)` This patch is as advice in apache#37799 (comment) . We tent to add time32 and time64 in `CommonTemporal`. ### What changes are included in this PR? Support time32 and time64 with different time unit in `arrow::compute::internal::CommonTemporal`. ### Are these changes tested? Yes ### Are there any user-facing changes? bugfix * Closes: apache#37799 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…64 casting (apache#37949) ### Rationale for this change The original problem in mentioned in apache#37799 1. `SECOND` in Parquet would always cast to `MILLS` 2. `eq` not support `eq(time32[s], time32[ms)` This patch is as advice in apache#37799 (comment) . We tent to add time32 and time64 in `CommonTemporal`. ### What changes are included in this PR? Support time32 and time64 with different time unit in `arrow::compute::internal::CommonTemporal`. ### Are these changes tested? Yes ### Are there any user-facing changes? bugfix * Closes: apache#37799 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…64 casting (apache#37949) ### Rationale for this change The original problem in mentioned in apache#37799 1. `SECOND` in Parquet would always cast to `MILLS` 2. `eq` not support `eq(time32[s], time32[ms)` This patch is as advice in apache#37799 (comment) . We tent to add time32 and time64 in `CommonTemporal`. ### What changes are included in this PR? Support time32 and time64 with different time unit in `arrow::compute::internal::CommonTemporal`. ### Are these changes tested? Yes ### Are there any user-facing changes? bugfix * Closes: apache#37799 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…64 casting (apache#37949) ### Rationale for this change The original problem in mentioned in apache#37799 1. `SECOND` in Parquet would always cast to `MILLS` 2. `eq` not support `eq(time32[s], time32[ms)` This patch is as advice in apache#37799 (comment) . We tent to add time32 and time64 in `CommonTemporal`. ### What changes are included in this PR? Support time32 and time64 with different time unit in `arrow::compute::internal::CommonTemporal`. ### Are these changes tested? Yes ### Are there any user-facing changes? bugfix * Closes: apache#37799 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The original problem in mentioned in #37799
SECONDin Parquet would always cast toMILLSeqnot supporteq(time32[s], time32[ms)This patch is as advice in #37799 (comment) . We tent to add time32 and time64 in
CommonTemporal.What changes are included in this PR?
Support time32 and time64 with different time unit in
arrow::compute::internal::CommonTemporal.Are these changes tested?
Yes
Are there any user-facing changes?
bugfix