Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37742: [Python] Enable Cython 3 #37743

Merged
merged 2 commits into from
Oct 5, 2023
Merged

GH-37742: [Python] Enable Cython 3 #37743

merged 2 commits into from
Oct 5, 2023

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Sep 15, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Enable Cython 3.

What changes are included in this PR?

  • Unpin Cython version in builds.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes, pyarrow will build with cython 3 by default.

@github-actions
Copy link

⚠️ GitHub issue #37742 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Member Author

danepitkin commented Sep 15, 2023 •
edited
Loading

TODO: Merge after #37097 lands and Cython 3.0.3 is released.

@danepitkin danepitkin mentioned this pull request Sep 15, 2023
Merged
@danepitkin danepitkin added this to the 14.0.0 milestone Sep 15, 2023
@danepitkin danepitkin mentioned this pull request Sep 15, 2023
Closed
@danepitkin danepitkin marked this pull request as draft September 15, 2023 17:18
@danepitkin danepitkin force-pushed the danepitkin/enable-cython3 branch from 34373da to 834e022 Compare September 21, 2023 15:09
@danepitkin
Copy link
Member Author

@github-actions crossbow submit -g python

@github-actions
Copy link

Revision: 834e022

Submitted crossbow builds: ursacomputing/crossbow @ actions-234a830b9b

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.10-cython2 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-v3.4.1 Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.11-spark-master Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.4.1 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 Github Actions

raulcd
raulcd reviewed Sep 26, 2023
View reviewed changes
ci/conda_env_python.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Sep 26, 2023
@danepitkin danepitkin force-pushed the danepitkin/enable-cython3 branch from 834e022 to a7c7946 Compare September 26, 2023 19:13
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 26, 2023
@danepitkin
Copy link
Member Author

@github-actions crossbow submit -g python

@github-actions
Copy link

Revision: a7c7946

Submitted crossbow builds: ursacomputing/crossbow @ actions-8f0b65f6be

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.10-cython2 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-v3.4.1 Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.11-spark-master Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.4.1 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 Github Actions

@danepitkin danepitkin force-pushed the danepitkin/enable-cython3 branch from a7c7946 to 3d1a44f Compare October 5, 2023 20:56
@danepitkin
Copy link
Member Author

Cython 3.0.3 is released! 🎉

@danepitkin
Copy link
Member Author

@github-actions crossbow submit -g python

@danepitkin danepitkin marked this pull request as ready for review October 5, 2023 20:58
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Revision: 3d1a44f

Submitted crossbow builds: ursacomputing/crossbow @ actions-354e90dcf7

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.10-cython2 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-v3.4.1 Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.11-spark-master Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.4.1 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 Github Actions

@danepitkin
Copy link
Member Author

CI failure for test-conda-python-3.11-hypothesis is a separate issue #38057

@danepitkin
Copy link
Member Author

CI failure for test-python-cuda is a separate issue #38059

@jorisvandenbossche
Copy link
Member

Great! Let's get this in then

@jorisvandenbossche jorisvandenbossche merged commit 41359dc into apache:main Oct 5, 2023
12 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting change review Awaiting change review label Oct 5, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 41359dc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
@danepitkin
apacheGH-37742: [Python] Enable Cython 3 (apache#37743)
34d0494 
### Rationale for this change

Enable Cython 3.

### What changes are included in this PR?

* Unpin Cython version in builds.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes, pyarrow will build with cython 3 by default.
* Closes: apache#37742

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@danepitkin @loicalleyne
apacheGH-37742: [Python] Enable Cython 3 (apache#37743)
b7acbce 
### Rationale for this change

Enable Cython 3.

### What changes are included in this PR?

* Unpin Cython version in builds.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes, pyarrow will build with cython 3 by default.
* Closes: apache#37742

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@danepitkin @dgreiss
apacheGH-37742: [Python] Enable Cython 3 (apache#37743)
ab7c2ac 
### Rationale for this change

Enable Cython 3.

### What changes are included in this PR?

* Unpin Cython version in builds.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes, pyarrow will build with cython 3 by default.
* Closes: apache#37742

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd left review comments

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
14.0.0
Development

Successfully merging this pull request may close these issues.

[Python] Enable Cython 3
3 participants
@danepitkin @jorisvandenbossche @raulcd