Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37715: [Packaging][CentOS] Use default g++ on CentOS 9 Stream #37718

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

kou
Copy link
Member

@kou kou commented Sep 14, 2023

Rationale for this change

We can use default g++ by using shared LLVM library.

What changes are included in this PR?

Use default g++ and remove needless llvm-static.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

We can use default g++ by using shared LLVM library.
@kou
Copy link
Member Author

kou commented Sep 14, 2023

@github-actions crossbow submit centos-9

@github-actions
Copy link

⚠️ GitHub issue #37715 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 14, 2023
@github-actions
Copy link

Revision: d9ca2cc

Submitted crossbow builds: ursacomputing/crossbow @ actions-be1267d65d

Task Status
centos-9-stream-amd64 Github Actions
centos-9-stream-arm64 Github Actions

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was necessary on previous versions due to the default g++ being to old?

@kou
Copy link
Member Author

kou commented Sep 15, 2023

We couldn't use static LLVM library with the default g++. See also: GH-13984 / GH-32792

@kou kou merged commit 49890e9 into apache:main Sep 15, 2023
@kou kou deleted the packaging-centos-9-stream-annobin branch September 15, 2023 02:32
@kou kou removed the awaiting committer review Awaiting committer review label Sep 15, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 49890e9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
apache#37718)

### Rationale for this change

We can use default g++ by using shared LLVM library.

### What changes are included in this PR?

Use default g++ and remove needless `llvm-static`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37715

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
apache#37718)

### Rationale for this change

We can use default g++ by using shared LLVM library.

### What changes are included in this PR?

Use default g++ and remove needless `llvm-static`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37715

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Packaging][CentOS] Failed to build RPM for CentOS 9 Stream
2 participants