-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37715: [Packaging][CentOS] Use default g++ on CentOS 9 Stream #37718
Conversation
We can use default g++ by using shared LLVM library.
@github-actions crossbow submit centos-9 |
|
Revision: d9ca2cc Submitted crossbow builds: ursacomputing/crossbow @ actions-be1267d65d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this was necessary on previous versions due to the default g++ being to old?
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 49890e9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
apache#37718) ### Rationale for this change We can use default g++ by using shared LLVM library. ### What changes are included in this PR? Use default g++ and remove needless `llvm-static`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37715 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
apache#37718) ### Rationale for this change We can use default g++ by using shared LLVM library. ### What changes are included in this PR? Use default g++ and remove needless `llvm-static`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37715 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
We can use default g++ by using shared LLVM library.
What changes are included in this PR?
Use default g++ and remove needless
llvm-static
.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.