-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37657: [JS] Run bin scripts with ts-node #37668
Conversation
…s to use ts-node in transpile-only mode, fix tsc errors in bin scripts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Eventually, we could even try running the benchmarks in e.g. bun so that we also have jscore as a comparison and not just v8 via node.
It seems that integration CI job failure is related to this: https://github.com/apache/arrow/actions/runs/6152750564/job/16695430388?pr=37668 Could you check the log? |
I just noticed that this open PR is expected to close #37657. That's great news! Could someone please take another look to see if we can merge and turn the benchmarking jobs green again? |
I'm happy to do another review. |
Hi, from my understanding benchmarks haven't been run for the last month or so for JS. It would be nice to re-enable them to validate we are not adding any performance issue on the Release. |
@ursabot please benchmark lang=JavaScript |
Benchmark runs are scheduled for commit 2ee36ea. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit 2ee36ea. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
I checked out this branch locally, rebased to If we don't merge this PR soon, I'm going to turn off the automatic benchmarking for JS since it's failing every time and covering up other errors like voltrondata-labs/arrow-benchmarks-ci#166. |
(rebased version of #37668, yarn.lock conflicts resolved in favor of main) * update bin scripts to use ts-node in transpile-only mode * remove ts-node config from top level tsconfig.json * fix tsc errors in bin scripts * Closes: #37657 Authored-by: ptaylor <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Should we close this PR as the other one has been merged? |
Yep, sorry I forgot to do that. |
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main) * update bin scripts to use ts-node in transpile-only mode * remove ts-node config from top level tsconfig.json * fix tsc errors in bin scripts * Closes: apache#37657 Authored-by: ptaylor <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main) * update bin scripts to use ts-node in transpile-only mode * remove ts-node config from top level tsconfig.json * fix tsc errors in bin scripts * Closes: apache#37657 Authored-by: ptaylor <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
tsconfig.json
tsc
errors in bin scriptsFixes #37657