-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37643: [C++] Enhance arrow::Datum::ToString #37646
Conversation
|
case Datum::ARRAY: | ||
return "Array"; | ||
return "Array(" + make_array()->ToString() + ")"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make_array
will generate a temp ::arrow::Array
object, don't know if we have a better way for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't think so. It won't be an O(N)
copy or anything though, so not the end of the world.
Seems this should also be fixed lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d9ee3a7. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
### Rationale for this change Add print child fields for `arrow::Datum::ToString`. Because previously it just print a type. ### What changes are included in this PR? Add detail in `arrow::Datum::ToString` ### Are these changes tested? no ### Are there any user-facing changes? Yes * Closes: apache#37643 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
### Rationale for this change Add print child fields for `arrow::Datum::ToString`. Because previously it just print a type. ### What changes are included in this PR? Add detail in `arrow::Datum::ToString` ### Are these changes tested? no ### Are there any user-facing changes? Yes * Closes: apache#37643 Authored-by: mwish <[email protected]> Signed-off-by: Benjamin Kietzman <[email protected]>
Rationale for this change
Add print child fields for
arrow::Datum::ToString
. Because previously it just print a type.What changes are included in this PR?
Add detail in
arrow::Datum::ToString
Are these changes tested?
no
Are there any user-facing changes?
Yes