Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tRecordBatch.m #37616

Closed
wants to merge 1 commit into from
Closed

Conversation

RANJITHROSAN17
Copy link

Rationale for this change

This pull request addresses the enhancement request outlined in GitHub issue #37592. The request is to add a NumRows property to the arrow.tabular.RecordBatch class in MATLAB's Arrow library. This enhancement aims to provide users with the ability to query the number of rows in a RecordBatch, which is a valuable functionality for data manipulation and analysis.

What changes are included in this PR?

In this PR, we have made the following changes to the code:

  • Added a NumRows property to the arrow.tabular.RecordBatch class.
  • Implemented a getter method for the NumRows property to retrieve the number of rows from the arrowRecordBatch property.

Are these changes tested?

Yes, the changes have been tested to ensure that the NumRows property correctly retrieves the number of rows from the underlying arrowRecordBatch object. Test cases have been added to validate the functionality.

Are there any user-facing changes?

Yes, this enhancement introduces a user-facing change by adding the NumRows property to the arrow.tabular.RecordBatch class. Users can now access the number of rows in a tRecordBatch object using tRecordBatch.NumRows.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kevingurney
Copy link
Member

kevingurney commented Sep 7, 2023

Hi @RANJITHROSAN17, thank you for contributing to the MATLAB interface to Arrow!

A few notes:

  1. It looks like the code for your pull request is incomplete. In order to add a NumRows property, you will most likely need to add a new getNumRows method to the RecordBatch C++ Proxy class and then call this Proxy method from a get.NumRows method on the MATLAB arrow.tabular.RecordBatch class. You can see the way we are planning to implement NumRows for arrow.tabular.Table for reference (C++ Proxy getNumRows member function and MATLAB get.NumRows method).
  2. If you haven't already, please refer to the New Contributor's Guide for helpful tips on getting started contributing to the Apache Arrow project.
  3. Pull request titles should follow the format: GH-<github-issue-id>: [<component>] <description> in order for automatic linking of a pull request to a GitHub issue to occur. For example, the title for this pull request should be: GH-37592: [MATLAB] Add NumRows property to arrow.tabular.RecordBatch.
  4. In general, it is a good idea for you to take ownership of an issue before you start working on it to inform others. You can take a GitHub issue by commenting take on the issue. For example, see: [MATLAB] Add arrow.array.ChunkedArray class #37448 (comment).

Please don't hesitate to ask questions if you run into issues.

Thanks!

@kevingurney
Copy link
Member

Hi @RANJITHROSAN17 - do you have any questions relating to this pull request? Is there anything we can do to help?

Thanks!

@kevingurney
Copy link
Member

@RANJITHROSAN17, just checking in again. Are you still interested in working on this issue? Do you need any help working this forward?

@kevingurney
Copy link
Member

kevingurney commented Oct 9, 2023

It looks like this pull request has gone stale.

Since having a NumRows property on arrow.tabular.RecordBatch is relatively important for an initial release of the MATLAB interface, I plan on following up with a pull request to add this.

Closing this pull request.

@kevingurney kevingurney closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants