GH-15058: [C++][Python] Native support for UUID #37298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Documentation
awaiting committer review
|
mentioned #15058 (comment) , do we need to remove that? |
rok
force-pushed
the
15058
branch
2 times, most recently
from
184e96c to
e738540
Compare
rok
force-pushed
the
15058
branch
8 times, most recently
from
16329bc to
a5283b6
Compare
Looks Ruby already got support for UUID? |
rok
force-pushed
the
15058
branch
2 times, most recently
from
3baa0a0 to
d8bfaf8
Compare
This was referenced Aug 23, 2024
|
Ping @jorisvandenbossche |
pitrou
approved these changes
Aug 26, 2024
|
Thanks everyone! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2328b6e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
Thanks a lot @rok! As another possible follow-up, would we want to support inferring and converting |
|
@jorisvandenbossche that sounds convenient! I've opened #43855 and will get around to it if someone else doesn't sooner :). |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Sep 3, 2024
### Rationale for this change See apache#15058. UUID datatype is common in throughout the ecosystem and Arrow as supporting it as a native type would reduce friction. ### What changes are included in this PR? This PR implements logic for Arrow canonical extension type in C++ and a Python wrapper. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes, new extension type is added. * Closes: apache#15058 Authored-by: Rok Mihevc <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
This was referenced Sep 11, 2024
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
### Rationale for this change See apache#15058. UUID datatype is common in throughout the ecosystem and Arrow as supporting it as a native type would reduce friction. ### What changes are included in this PR? This PR implements logic for Arrow canonical extension type in C++ and a Python wrapper. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes, new extension type is added. * Closes: apache#15058 Authored-by: Rok Mihevc <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
ianmcook
added a commit
that referenced
this pull request
Sep 17, 2024
### Rationale for this change UUID extension types were made canonical in #41299 and are getting native support in C++ and Python in #37298. As such, it makes sense to provide an alternative user-defined extension type as an example that is unlikely to become a canonical extension type anytime soon. After discussion in #43809, we determined a `RationalType` would make sense. Please note that this is a redo of #43849 as I made a blunder and accidentally pushed a branch that was in a wonky state. ### What changes are included in this PR? A change in several doc locations which reference a `UuidType` extension type have been changed to a `RationalType`. For consistency, this PR also changes single quotes (`''`) to double quotes (`""`) throughout the Python examples that it modifies. Also, seemingly unrelated to this change, some doctests began failing as numpy changed the `repr` of `float16`'s between 1.x and 2.x. We have updated the failing doctest so that it supports both styles. ### Are these changes tested? These are documentation changes and `archery docker run conda-python-docs` succeeds locally. ### Are there any user-facing changes? No. cc @ianmcook @rok * GitHub Issue: #43809 --------- Co-authored-by: Ian Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #15058.
UUID datatype is common in throughout the ecosystem and Arrow as supporting it as a native type would reduce friction.
What changes are included in this PR?
This PR implements logic for Arrow canonical extension type in C++ and a Python wrapper.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, new extension type is added.