Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36947: [CI] Move free up disk space to the Jinja macros to be able to reuse it on docs job #36948

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 31, 2023

Rationale for this change

Try to get rid of some failures on docs generation on release and reuse existing code.

What changes are included in this PR?

Move step to a macro to be able to reuse it

Are these changes tested?

Archery tasks

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@github-actions crossbow submit test-ubuntu-22.04-docs

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 31, 2023
@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@github-actions crossbow submit -g linux

@github-actions
Copy link

Revision: aa823b2

Submitted crossbow builds: ursacomputing/crossbow @ actions-a80b3bfb36

Task Status
test-ubuntu-22.04-docs Github Actions

@github-actions
Copy link

Revision: aa823b2

Submitted crossbow builds: ursacomputing/crossbow @ actions-35c61b8c04

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 Github Actions
almalinux-9-amd64 Github Actions
almalinux-9-arm64 Github Actions
amazon-linux-2023-amd64 Github Actions
amazon-linux-2023-arm64 Github Actions
centos-7-amd64 Github Actions
centos-8-stream-amd64 Github Actions
centos-8-stream-arm64 Github Actions
centos-9-stream-amd64 Github Actions
centos-9-stream-arm64 Github Actions
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 Github Actions
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 Github Actions
debian-trixie-amd64 Github Actions
debian-trixie-arm64 Github Actions
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 Github Actions
ubuntu-jammy-amd64 Github Actions
ubuntu-jammy-arm64 Github Actions
ubuntu-lunar-amd64 Github Actions
ubuntu-lunar-arm64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 31, 2023

@kou I just saw you merged this: #36941
Thanks!!!
What do you think of this one? I can remove it from the docs but I still think might be worth it to move it to the macros in case we want to reuse it temporarily.

@raulcd raulcd changed the title GH-36947: [CI] Move free up disk space to its own action and use it on docs job GH-36947: [CI] Move free up disk space to the Jinja macros to be able to reuse it on docs job Jul 31, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I think that this is also useful for docs and other jobs.

dev/tasks/macros.jinja Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 31, 2023
@raulcd
Copy link
Member Author

raulcd commented Aug 1, 2023

@github-actions crossbow submit test-ubuntu-22.04-docs

@raulcd
Copy link
Member Author

raulcd commented Aug 1, 2023

@github-actions crossbow submit -g linux

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Revision: 16a2e44

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c9afc39a2

Task Status
test-ubuntu-22.04-docs Github Actions

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Revision: 16a2e44

Submitted crossbow builds: ursacomputing/crossbow @ actions-8b267107a1

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 Github Actions
almalinux-9-amd64 Github Actions
almalinux-9-arm64 Github Actions
amazon-linux-2023-amd64 Github Actions
amazon-linux-2023-arm64 Github Actions
centos-7-amd64 Github Actions
centos-8-stream-amd64 Github Actions
centos-8-stream-arm64 Github Actions
centos-9-stream-amd64 Github Actions
centos-9-stream-arm64 Github Actions
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 Github Actions
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 Github Actions
debian-trixie-amd64 Github Actions
debian-trixie-arm64 Github Actions
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 Github Actions
ubuntu-jammy-amd64 Github Actions
ubuntu-jammy-arm64 Github Actions
ubuntu-lunar-amd64 Github Actions
ubuntu-lunar-arm64 Github Actions

@raulcd raulcd merged commit 66a6136 into apache:main Aug 1, 2023
6 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Aug 1, 2023
raulcd added a commit that referenced this pull request Aug 1, 2023
… to reuse it on docs job (#36948)

### Rationale for this change

Try to get rid of some failures on docs generation on release and reuse existing code.

### What changes are included in this PR?

Move step to a macro to be able to reuse it

### Are these changes tested?

Archery tasks

### Are there any user-facing changes?

No
* Closes: #36947

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 66a6136.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
…e able to reuse it on docs job (apache#36948)

### Rationale for this change

Try to get rid of some failures on docs generation on release and reuse existing code.

### What changes are included in this PR?

Move step to a macro to be able to reuse it

### Are these changes tested?

Archery tasks

### Are there any user-facing changes?

No
* Closes: apache#36947

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…e able to reuse it on docs job (apache#36948)

### Rationale for this change

Try to get rid of some failures on docs generation on release and reuse existing code.

### What changes are included in this PR?

Move step to a macro to be able to reuse it

### Are these changes tested?

Archery tasks

### Are there any user-facing changes?

No
* Closes: apache#36947

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Move Free up disk space for GitHub runners on to a macro to be able to reuse
2 participants