-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36839: [CI][Docs] Update test-ubuntu-default-docs to use GitHub actions instead of Azure #36840
Conversation
…Hub actions instead of Azure
@github-actions crossbow submit test-ubuntu-default-docs |
@github-actions crossbow submit preview-docs |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-ubuntu-default-docs |
Revision: 5277737 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c4e6ae8e9
|
@github-actions crossbow submit preview-docs |
Revision: 5277737 Submitted crossbow builds: ursacomputing/crossbow @ actions-a223edc8a5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
params: | ||
artifacts: "build/docs.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep this to validate uploaded artifacts (archery crossbow --validate
) after uploading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't line 1445 below for that:
artifacts:
- docs.tar.gz
I think this was unused but I might be confused.
The validation seems correct on the job triggered via crossbow: https://github.com/ursacomputing/crossbow/actions/runs/5643790115/job/15286296284#step:14:24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! You're right!
…tions instead of Azure (#36840) ### Rationale for this change Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation. Using the same base action for both preview-docs, test and packaging will improve maintainability. ### What changes are included in this PR? Move `test-ubuntu-default-docs` to use GH actions instead of Azure. ### Are these changes tested? Yes, with archery related tasks. ### Are there any user-facing changes? No * Closes: #36839 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 06deded. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
…Hub actions instead of Azure (apache#36840) ### Rationale for this change Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation. Using the same base action for both preview-docs, test and packaging will improve maintainability. ### What changes are included in this PR? Move `test-ubuntu-default-docs` to use GH actions instead of Azure. ### Are these changes tested? Yes, with archery related tasks. ### Are there any user-facing changes? No * Closes: apache#36839 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…Hub actions instead of Azure (apache#36840) ### Rationale for this change Currently `test-ubuntu-default-docs` has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation. Using the same base action for both preview-docs, test and packaging will improve maintainability. ### What changes are included in this PR? Move `test-ubuntu-default-docs` to use GH actions instead of Azure. ### Are these changes tested? Yes, with archery related tasks. ### Are there any user-facing changes? No * Closes: apache#36839 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Currently
test-ubuntu-default-docs
has been failing on Azure for the 13.0.0 RC0 and we had to use GitHub actions to generate the documentation.Using the same base action for both preview-docs, test and packaging will improve maintainability.
What changes are included in this PR?
Move
test-ubuntu-default-docs
to use GH actions instead of Azure.Are these changes tested?
Yes, with archery related tasks.
Are there any user-facing changes?
No