GH-36696: [Go] Improve the MapOf and ListOf helpers #36697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* Removed references to panics I can't find * Updated error messages for list and map to be clearer with validation errors * Added a ListOfWithName to provide a clearer matching method to MapOf which takes a name
wolfeidau
force-pushed
the
feat_list_with_name
branch
from
dab43fc to
bf8efbb
Compare
zeroshade
reviewed
Jul 17, 2023
go/parquet/schema/helpers.go
Outdated
| return nil, xerrors.Errorf("parquet: listof repetition must not be repeated, got :%s", rep) | ||
| } | ||
|
|
||
| if rep == parquet.Repetitions.Repeated || element.RepetitionType() == parquet.Repetitions.Repeated { |
There was a problem hiding this comment.
rep == parquet.Repetitions.Repeated is redundant here as it is already checked above this.
github-actions
bot
added
awaiting changes
zeroshade
previously approved these changes
Jul 17, 2023
github-actions
bot
added
awaiting merge
zeroshade
requested changes
Jul 17, 2023
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
@zeroshade sorry for the duplication, I really should have picked this up. Also sorted out the checks to actually do what I intended, which was make the error messages clearer and more specific to the check performed. |
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 15ee521. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
### Rationale for this change The aim is to improve the MapOf and ListOf helper functions without breaking anything. I have added a `ListOfWithName` which matches the `MapOf` function in that it takes a name, rather than deriving it from the elements name, which should actually be `element`. This just seems clearer to me as an interface, and makes construction a bit more obvious. ### What changes are included in this PR? * Removed references to panics I can't find * Updated error messages for list and map to be clearer with validation errors * Added a ListOfWithName to provide a clearer matching method to MapOf which takes a name Closes apache#36696 ### Are these changes tested? Yes, I added a test for the new `ListOfWithName` function. ### Are there any user-facing changes? * Closes: apache#36696 Authored-by: Mark Wolfe <[email protected]> Signed-off-by: Matt Topol <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change The aim is to improve the MapOf and ListOf helper functions without breaking anything. I have added a `ListOfWithName` which matches the `MapOf` function in that it takes a name, rather than deriving it from the elements name, which should actually be `element`. This just seems clearer to me as an interface, and makes construction a bit more obvious. ### What changes are included in this PR? * Removed references to panics I can't find * Updated error messages for list and map to be clearer with validation errors * Added a ListOfWithName to provide a clearer matching method to MapOf which takes a name Closes apache#36696 ### Are these changes tested? Yes, I added a test for the new `ListOfWithName` function. ### Are there any user-facing changes? * Closes: apache#36696 Authored-by: Mark Wolfe <[email protected]> Signed-off-by: Matt Topol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The aim is to improve the MapOf and ListOf helper functions without breaking anything. I have added a
ListOfWithNamewhich matches theMapOffunction in that it takes a name, rather than deriving it from the elements name, which should actually beelement.This just seems clearer to me as an interface, and makes construction a bit more obvious.
What changes are included in this PR?
Closes #36696
Are these changes tested?
Yes, I added a test for the new
ListOfWithNamefunction.Are there any user-facing changes?