GH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when comparing with other type #36661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comparing with other type
|
|
github-actions
bot
added
Component: Python
awaiting committer review
|
@github-actions crossbow submit dask |
|
Revision: 492ba09 Submitted crossbow builds: ursacomputing/crossbow @ actions-fc21bc16e4
|
1 task
|
The failures seems related to not having rebased after: 3bdbd0d |
|
Indeed, so the actual segfault is fixed by this PR, so that looks good. |
raulcd
reviewed
Jul 13, 2023
github-actions
bot
added
awaiting changes
raulcd
approved these changes
Jul 13, 2023
github-actions
bot
added
awaiting merge
raulcd
pushed a commit
that referenced
this pull request
Jul 13, 2023
…ring with other type (#36661) ### Rationale for this change Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance Small follow-up on #36462 * Closes: #36659 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this pull request
Jul 20, 2023
… comparing with other type (apache#36661) ### Rationale for this change Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance Small follow-up on apache#36462 * Closes: apache#36659 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 994c73b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
… comparing with other type (apache#36661) ### Rationale for this change Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance Small follow-up on apache#36462 * Closes: apache#36659 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
anjakefala
added
the
Critical Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Ensure that
part == otherdoesn't crash withotheris not a Partitioning instanceSmall follow-up on #36462