-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36629: [CI][Python] Skip dask tests due to our non-nanosecond changes in arrow->pandas conversion #36630
Conversation
…d changes in arrow->pandas conversion
@github-actions crossbow submit dask |
|
@jorisvandenbossche as you suggested I skipped the test, is there an issue we should create to follow it up? |
Revision: 6364629 Submitted crossbow builds: ursacomputing/crossbow @ actions-6841a6feb4
|
@github-actions crossbow submit dask |
Revision: 6364629 Submitted crossbow builds: ursacomputing/crossbow @ actions-f91d54dfef
|
The upstream_devel one is now segfaulting while running the tests. But I assume that is a new / separate issue, because I see it's also happening in the nightly ones. Will try to investigate or check when this started. |
…ges in arrow->pandas conversion (#36630) ### Rationale for this change Due to the changes on #33321 a dask test started failing. ### What changes are included in this PR? Skip the test in the meantime ### Are these changes tested? Yes, with crossbow ### Are there any user-facing changes? No * Closes: #36629 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Let's create a reminder to remove the skip again, yes -> #36666 |
fyi dask/dask#10412. |
…d changes in arrow->pandas conversion (apache#36630) ### Rationale for this change Due to the changes on apache#33321 a dask test started failing. ### What changes are included in this PR? Skip the test in the meantime ### Are these changes tested? Yes, with crossbow ### Are there any user-facing changes? No * Closes: apache#36629 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3bdbd0d. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…d changes in arrow->pandas conversion (apache#36630) ### Rationale for this change Due to the changes on apache#33321 a dask test started failing. ### What changes are included in this PR? Skip the test in the meantime ### Are these changes tested? Yes, with crossbow ### Are there any user-facing changes? No * Closes: apache#36629 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Rationale for this change
Due to the changes on #33321 a dask test started failing.
What changes are included in this PR?
Skip the test in the meantime
Are these changes tested?
Yes, with crossbow
Are there any user-facing changes?
No
dask.dataframe.io.tests.test_parquet::test_pandas_timestamp_overflow_pyarrow
#36629