Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36599: [MATLAB] Bump libmexclass version to 3465900 #36600

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

sgilmore10
Copy link
Member

@sgilmore10 sgilmore10 commented Jul 10, 2023

Rationale for this change

We recently made some improvements to libmexclass that include creating a class named libmexclass.proxy.Identifier which represents proxy ids. This class will be helpful when we create arrowy.array.Array objects from existing proxy ids, which used to be represented as scalar uint64 values.

What changes are included in this PR?

  1. Bumps the libmexclass version the MATLAB Interface depends on to #3465900

Are these changes tested?

No tests needed.

Are there any user-facing changes?

No.

Copy link
Member

@kevingurney kevingurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kevingurney kevingurney changed the title GH-36599: [MATLAB] Bump libmexclass version 3465900 GH-36599: [MATLAB] Bump libmexclass version to 3465900 Jul 10, 2023
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jul 10, 2023
@kevingurney kevingurney merged commit d676078 into apache:main Jul 10, 2023
@kevingurney kevingurney removed the awaiting committer review Awaiting committer review label Jul 10, 2023
@sgilmore10 sgilmore10 deleted the GH-36599 branch July 10, 2023 18:36
raulcd pushed a commit that referenced this pull request Jul 11, 2023
### Rationale for this change

We recently made some improvements to `libmexclass` that include creating a class named `libmexclass.proxy.Identifier` which represents proxy ids. This class will be helpful when we create `arrowy.array.Array` objects from existing proxy ids, which used to be represented as scalar `uint64` values.

### What changes are included in this PR?

1. Bumps the libmexclass version the MATLAB Interface depends on to [#3465900](mathworks/libmexclass@3465900) 

### Are these changes tested?

No tests needed.

### Are there any user-facing changes?

No.

* Closes: #36599

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d676078.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MATLAB] Bump libmexclass version to 3465900
2 participants