Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36311: [C++] Fix integer overflows in utf8_slice_codeunits #36575

Merged
merged 5 commits into from
Jul 11, 2023
Merged

GH-36311: [C++] Fix integer overflows in utf8_slice_codeunits #36575

merged 5 commits into from
Jul 11, 2023

Commits on Jul 9, 2023

  1. Avoid overflows in SliceCodunitsTransform

    @benibus
    benibus committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    3a5f286 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Handle INT64_MIN in SliceCodeunitsTransform 

    Also reorganizes C++ tests
    @benibus
    benibus committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    40a7afc View commit details
    Browse the repository at this point in the history

  2. Update Python bindings for SliceOptions 

    When `stop=None`, negates the default value of `sys.maxsize` if `step <
0` to mimic the behavior of Python arrays
    @benibus
    benibus committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    f6e013e View commit details
    Browse the repository at this point in the history

  3. Test stop=None for Python

    @benibus
    benibus committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    03fa729 View commit details
    Browse the repository at this point in the history

  4. Fix negation UB

    @benibus
    benibus committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    58eb873 View commit details
    Browse the repository at this point in the history