Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36433: [C++] Update fast_float version to 3.10.1 #36434

Merged
merged 18 commits into from
Jul 19, 2023
Merged

GH-36433: [C++] Update fast_float version to 3.10.1 #36434

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
68c7eec
GH-36433 updated fast_float version to 5.2.0
xxlaykxx Jul 2, 2023
92b5adf
Update fast_float version
xxlaykxx Jul 4, 2023
81abdaa
Define FASTFLOAT_ALLOWS_LEADING_PLUS
xxlaykxx Jul 7, 2023
99f4b61
define FASTFLOAT_ALLOWS_LEADING_PLUS
xxlaykxx Jul 7, 2023
75f4fc3
move define to valuer_parsing class, added tests
xxlaykxx Jul 10, 2023
dcc6cfa
fixed test
xxlaykxx Jul 10, 2023
d1fd764
fixed tests
xxlaykxx Jul 10, 2023
ab215ad
fixed tests
xxlaykxx Jul 10, 2023
cfbf691
fixed formating
xxlaykxx Jul 10, 2023
7da736e
fixed formating
xxlaykxx Jul 10, 2023
028b175
Merge branch 'apache:main' into GH-36433
xxlaykxx Jul 11, 2023
3a3b5fc
Moving define
xxlaykxx Jul 14, 2023
d8ca8b9
fix define
xxlaykxx Jul 14, 2023
b0ddd25
fixed formating
xxlaykxx Jul 14, 2023
5045b35
fixed comment
xxlaykxx Jul 17, 2023
dbdaea0
Update cpp/src/arrow/util/value_parsing.cc
xxlaykxx Jul 18, 2023
2a5eef6
Merge branch 'apache:main' into GH-36433
xxlaykxx Jul 18, 2023
89e16f0
Merge branch 'apache:main' into GH-36433
xxlaykxx Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/src/arrow/util/value_parsing.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
#ifndef FASTFLOAT_ALLOWS_LEADING_PLUS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ifndef? What situation are you thinking? I think that this is needless...

#define FASTFLOAT_ALLOWS_LEADING_PLUS 1
xxlaykxx marked this conversation as resolved.
Show resolved Hide resolved

#include "arrow/util/value_parsing.h"

Expand Down Expand Up @@ -112,3 +114,5 @@ std::shared_ptr<TimestampParser> TimestampParser::MakeISO8601() {
}

} // namespace arrow

#endif