Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35273: [C++] Add integer round kernels #36289

Merged
merged 12 commits into from
Aug 9, 2023
Merged

GH-35273: [C++] Add integer round kernels #36289

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6fc5dc3
add integer round kernels
js8544 Jun 22, 2023
063e73e
lint
js8544 Jun 22, 2023
f1a2729
fix warning
js8544 Jun 22, 2023
627cc1a
fix existing tests
js8544 Jun 22, 2023
eb5a739
pr feedback
js8544 Jul 6, 2023
de3c289
add overflow test cast
js8544 Jul 6, 2023
89fc535
integer round use naive approach
js8544 Jul 16, 2023
4b4e85a
Update docs/source/cpp/compute.rst
js8544 Jul 17, 2023
f1f35f0
lint
js8544 Jul 16, 2023
f0c2eae
review feedback
js8544 Jul 27, 2023
88d2619
Update docs/source/cpp/compute.rst
js8544 Aug 9, 2023
0a8d38d
fix doc
js8544 Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/src/arrow/compute/kernels/codegen_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ template <typename T>
using is_signed_integer_value =
std::integral_constant<bool, std::is_integral<T>::value && std::is_signed<T>::value>;

template <typename T>
using is_integer_value =
std::integral_constant<bool, is_signed_integer_value<T>::value ||
is_unsigned_integer_value<T>::value>;

template <typename T, typename R = T>
using enable_if_signed_integer_value = enable_if_t<is_signed_integer_value<T>::value, R>;

Expand Down
Loading