-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35329: [Python] Address pandas.types.is_sparse deprecation #35366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! +1
The MacOS failure is not related.
|
Benchmark runs are scheduled for baseline = b73ddc3 and contender = de6c3cd. de6c3cd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…pache#35366) ### Rationale for this change pandas is deprecating `pandas.types.is_sparse` in 2.1 ### What changes are included in this PR? Changing usages of `is_sparse` to the recommended migration `isinstance(dtype, pd.SparseDtype)` ### Are these changes tested? ### Are there any user-facing changes? No closes apache#35329 * Closes: apache#35329 Authored-by: Matthew Roeschke <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
…pache#35366) ### Rationale for this change pandas is deprecating `pandas.types.is_sparse` in 2.1 ### What changes are included in this PR? Changing usages of `is_sparse` to the recommended migration `isinstance(dtype, pd.SparseDtype)` ### Are these changes tested? ### Are there any user-facing changes? No closes apache#35329 * Closes: apache#35329 Authored-by: Matthew Roeschke <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
…pache#35366) ### Rationale for this change pandas is deprecating `pandas.types.is_sparse` in 2.1 ### What changes are included in this PR? Changing usages of `is_sparse` to the recommended migration `isinstance(dtype, pd.SparseDtype)` ### Are these changes tested? ### Are there any user-facing changes? No closes apache#35329 * Closes: apache#35329 Authored-by: Matthew Roeschke <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
### Rationale for this change pandas is deprecating `pandas.types.is_sparse` in 2.1 ### What changes are included in this PR? Changing usages of `is_sparse` to the recommended migration `isinstance(dtype, pd.SparseDtype)` ### Are these changes tested? ### Are there any user-facing changes? No closes #35329 * Closes: #35329 Authored-by: Matthew Roeschke <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
I think this only fixes the issue in python/pyarrow/pandas-shim.pxi, but is_sparse() is also used here: |
Rationale for this change
pandas is deprecating
pandas.types.is_sparse
in 2.1What changes are included in this PR?
Changing usages of
is_sparse
to the recommended migrationisinstance(dtype, pd.SparseDtype)
Are these changes tested?
Are there any user-facing changes?
No
closes #35329