Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35025: [Python] Remove use of deprecated pandas.Categorical fastpath keyword #35026

Merged
merged 1 commit into from
Apr 11, 2023
Merged

GH-35025: [Python] Remove use of deprecated pandas.Categorical fastpath keyword #35026

merged 1 commit into from
Apr 11, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 11, 2023 •
edited by github-actions bot
Loading

Rationale for this change

We are using pd.Categorical(codes, categories, fastpath=True). This keyword is deprecated in pandas 2.1 and this should be changed to pd.Categorical.from_codes(codes, categories).

Are there any user-facing changes?

No

@github-actions
Copy link

@jorisvandenbossche jorisvandenbossche merged commit e488942 into apache:main Apr 11, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-35025-categorical-fastpath branch April 11, 2023 09:59
@ursabot
Copy link

ursabot commented Apr 12, 2023

Benchmark runs are scheduled for baseline = 61b89df and contender = e488942. e488942 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e488942c ec2-t3-xlarge-us-east-2
[Failed] e488942c test-mac-arm
[Finished] e488942c ursa-i9-9960x
[Finished] e488942c ursa-thinkcentre-m75q
[Finished] 61b89df5 ec2-t3-xlarge-us-east-2
[Failed] 61b89df5 test-mac-arm
[Finished] 61b89df5 ursa-i9-9960x
[Finished] 61b89df5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

mikelui pushed a commit to mikelui/arrow that referenced this pull request Apr 14, 2023
@jorisvandenbossche
apacheGH-35025: [Python] Remove use of deprecated pandas.Categorical …
208ac6f 
…fastpath keyword (apache#35026)

We are using `pd.Categorical(codes, categories, fastpath=True)`. This keyword is deprecated in pandas 2.1 and this should be changed to `pd.Categorical.from_codes(codes, categories)`.

No
* Closes: apache#35025

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@jorisvandenbossche @liujiacheng777
apacheGH-35025: [Python] Remove use of deprecated pandas.Categorical …
a501621 
…fastpath keyword (apache#35026)

### Rationale for this change
We are using `pd.Categorical(codes, categories, fastpath=True)`. This keyword is deprecated in pandas 2.1 and this should be changed to `pd.Categorical.from_codes(codes, categories)`.

### Are there any user-facing changes?
No
* Closes: apache#35025

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-35025: [Python] Remove use of deprecated pandas.Categorical …
69cf0c7 
…fastpath keyword (apache#35026)

### Rationale for this change
We are using `pd.Categorical(codes, categories, fastpath=True)`. This keyword is deprecated in pandas 2.1 and this should be changed to `pd.Categorical.from_codes(codes, categories)`.

### Are there any user-facing changes?
No
* Closes: apache#35025

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@jorisvandenbossche @rtpsw
apacheGH-35025: [Python] Remove use of deprecated pandas.Categorical …
bca164b 
…fastpath keyword (apache#35026)

### Rationale for this change
We are using `pd.Categorical(codes, categories, fastpath=True)`. This keyword is deprecated in pandas 2.1 and this should be changed to `pd.Categorical.from_codes(codes, categories)`.

### Are there any user-facing changes?
No
* Closes: apache#35025

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlenkaF AlenkaF AlenkaF approved these changes

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Update use of deprecated pandas.Categorical fastpath keyword
3 participants
@jorisvandenbossche @ursabot @AlenkaF