GH-34216: [Python] Support for reading JSON Datasets With Python #34586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ARROW-34216 merge
github-actions
bot
added
Component: C++
Component: Python
awaiting review
R-JunmingChen
changed the title
westonpace
requested changes
Mar 21, 2023
github-actions
bot
added
awaiting changes
jorisvandenbossche
changed the title
Co-authored-by: Weston Pace <[email protected]>
Co-authored-by: Weston Pace <[email protected]>
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
Hi, I have added some tests, which references the csv tests. Please review them when you are free |
westonpace
requested changes
Apr 10, 2023
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting committer review
github-actions
bot
removed
the
awaiting committer review
westonpace
approved these changes
Apr 12, 2023
github-actions
bot
added
awaiting review
|
Benchmark runs are scheduled for baseline = 0434ab6 and contender = 4963105. 4963105 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
apache#34586) This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported. Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd. Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. **What changes are included in this PR?** C++: add inclusion for file_json.h Python: reference C++ codes and support reading JSON Datasets **Are these changes tested?** Yes 6 test samples added in tests/test_dataset.py * Closes: apache#34216 Lead-authored-by: Junming Chen <[email protected]> Co-authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
apache#34586) This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported. Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd. Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. **What changes are included in this PR?** C++: add inclusion for file_json.h Python: reference C++ codes and support reading JSON Datasets **Are these changes tested?** Yes 6 test samples added in tests/test_dataset.py * Closes: apache#34216 Lead-authored-by: Junming Chen <[email protected]> Co-authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
apache#34586) This PR supports for reading JSON Datasets With Python. As mentioned in [apache#34216](apache#34216), only the reading ability are supported. Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd. Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't. **What changes are included in this PR?** C++: add inclusion for file_json.h Python: reference C++ codes and support reading JSON Datasets **Are these changes tested?** Yes 6 test samples added in tests/test_dataset.py * Closes: apache#34216 Lead-authored-by: Junming Chen <[email protected]> Co-authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports for reading JSON Datasets With Python. As mentioned in #34216, only the reading ability are supported.
Please compare the difference between my implemenation of _json.pyx, _json.pyd and _csv.pyx _csv.pyd.
Cause _csv.pyd utilize pointer for cpp class and my implementation doesn't.
What changes are included in this PR?
C++: add inclusion for file_json.h
Python: reference C++ codes and support reading JSON Datasets
Are these changes tested?
Yes
6 test samples added in tests/test_dataset.py