Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34330: [Go][Parquet]: Add Extension type support #34356

Closed
wants to merge 2 commits into from
Closed

GH-34330: [Go][Parquet]: Add Extension type support #34356

wants to merge 2 commits into from

Conversation

yevgenypats
Copy link
Contributor

@yevgenypats yevgenypats commented Feb 26, 2023 •
edited by github-actions bot
Loading

Closes #34330.

This is still WIP as missing some logic around path_builder.go but I wanted to open this PR for initial review to make sure Im moving in the right direction.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #34330 has been automatically assigned in GitHub to PR creator.

@yevgenypats yevgenypats changed the title GH-34330: [Go] Parquet: Add Extension type support GH-34330: [Go][Parquet]: Add Extension type support Feb 26, 2023
@yevgenypats yevgenypats force-pushed the feat/go/parque_extensions branch from 0602c0d to e61d7ca Compare March 8, 2023 18:19
@github-actions github-actions bot added the awaiting review Awaiting review label Mar 8, 2023
@yevgenypats
Copy link
Contributor Author

@zeroshade can you help me on how I get the PARQUET_TEST_DATA should I download it from somewhere (need it to to be able to run tests locally)?

@zeroshade
Copy link
Member

@yevgenypats it's a submodule in the repo. you should be able to run git submodule update from the root of the repo and it'll pull down the test data. Then you just need to set PARQUET_TEST_DATA=<ARROW_ROOT>/cpp/submodules/parquet-testing

@yevgenypats yevgenypats mentioned this pull request Mar 18, 2023
Merged
@yevgenypats
Copy link
Contributor Author

Closing in favour of #34631

zeroshade pushed a commit that referenced this pull request Apr 12, 2023
@yevgenypats @hermanschaaf
GH-34330: [Go][Parquet]: Add Extension type support (#34631)
c2904b0 
Follow-up instead of #34356
* Closes: #34330

This is not yet complete but I would love some direction on where should I add tests and in what other places I should handle the new extension type.

Lead-authored-by: Kemal Hadimli <[email protected]>
Co-authored-by: Herman Schaaf <[email protected]>
Co-authored-by: Yevgeny Pats <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@yevgenypats @hermanschaaf @liujiacheng777
apacheGH-34330: [Go][Parquet]: Add Extension type support (apache#34631)
955254f 
Follow-up instead of apache#34356
* Closes: apache#34330

This is not yet complete but I would love some direction on where should I add tests and in what other places I should handle the new extension type.

Lead-authored-by: Kemal Hadimli <[email protected]>
Co-authored-by: Herman Schaaf <[email protected]>
Co-authored-by: Yevgeny Pats <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@yevgenypats @hermanschaaf @ArgusLi
apacheGH-34330: [Go][Parquet]: Add Extension type support (apache#34631)
b036bd7 
Follow-up instead of apache#34356
* Closes: apache#34330

This is not yet complete but I would love some direction on where should I add tests and in what other places I should handle the new extension type.

Lead-authored-by: Kemal Hadimli <[email protected]>
Co-authored-by: Herman Schaaf <[email protected]>
Co-authored-by: Yevgeny Pats <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@yevgenypats @hermanschaaf @rtpsw
apacheGH-34330: [Go][Parquet]: Add Extension type support (apache#34631)
a334a06 
Follow-up instead of apache#34356
* Closes: apache#34330

This is not yet complete but I would love some direction on where should I add tests and in what other places I should handle the new extension type.

Lead-authored-by: Kemal Hadimli <[email protected]>
Co-authored-by: Herman Schaaf <[email protected]>
Co-authored-by: Yevgeny Pats <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
kou pushed a commit to apache/arrow-go that referenced this pull request Aug 30, 2024
@yevgenypats @hermanschaaf @kou
GH-34330: [Go][Parquet]: Add Extension type support (#34631)
1308c87 
Follow-up instead of apache/arrow#34356
* Closes: #34330

This is not yet complete but I would love some direction on where should I add tests and in what other places I should handle the new extension type.

Lead-authored-by: Kemal Hadimli <[email protected]>
Co-authored-by: Herman Schaaf <[email protected]>
Co-authored-by: Yevgeny Pats <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

Assignees
No one assigned
Labels
awaiting review Awaiting review Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] Parquet file handling extensions
2 participants
@yevgenypats @zeroshade