ARROW-14999: [C++] Optional field name equality checks for map and list type #14847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Java
Component: Python
Component: R
labels
|
Seems like the Java test changes won't work as the latest stable PyArrow is used? |
I'm pretty sure it uses local PyArrow. I got the tests passing in the other PR. I think the error is just that I added |
|
CI failures are unrelated. |
paleolimbot
approved these changes
Dec 6, 2022
pitrou
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Thanks a lot @wjones127 ! This looks good on the princople, a couple minor comments.
Co-authored-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Two changes for "internal fields" (fields within ListTypes and MapTypes):
check_metadataistrue.