ARROW-2651: [Python] Fix datetime C API import for PyPy #14539
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
mattip
changed the title
| #ifdef PYPY_VERSION | ||
| #include "datetime.h" | ||
| #else | ||
| #define PyDateTimeAPI ::arrow::py::internal::datetime_api |
There was a problem hiding this comment.
Can we keep indentation consistent?
| @@ -40,7 +40,11 @@ static Status UnwrapError(PyObject* obj, const char* expected_type) { | |||
| } | |||
|
|
|||
| int import_pyarrow() { | |||
| #ifdef PYPY_VERSION | |||
| PyDateTime_IMPORT; | |||
pitrou
changed the title
|
I see that CI passed on your fork. Failures here are unrelated. |
|
Thanks! |
|
Benchmark runs are scheduled for baseline = 1164785 and contender = 2a5c773. 2a5c773 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
As described in the ARROW-2651 issue, this patch fixes the C datetime module import mechanism for PyPy.
This is related to #2089 which was closed in favor of the JIRA issue.