Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17431: [Java] MapBinder to bind Arrow Map type to DB column #13941

Merged
merged 2 commits into from
Aug 24, 2022
Merged

ARROW-17431: [Java] MapBinder to bind Arrow Map type to DB column #13941

merged 2 commits into from
Aug 24, 2022

Conversation

igor-suhorukov
Copy link
Contributor

Typical real life Arrow datasets contain map of primitive type. This PR introduce MapBinder mapping of primitive types map entries

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17431

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm lidavidm self-requested a review August 22, 2022 21:00
lidavidm
lidavidm reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Just one question about the test coverage.

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcParameterBinderTest.java Show resolved Hide resolved
lidavidm
lidavidm approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidavidm lidavidm merged commit 712e06b into apache:master Aug 24, 2022
@igor-suhorukov igor-suhorukov mentioned this pull request Aug 24, 2022
Closed
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = 965e761 and contender = 712e06b. 712e06b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.11% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 712e06bc ec2-t3-xlarge-us-east-2
[Failed] 712e06bc test-mac-arm
[Failed] 712e06bc ursa-i9-9960x
[Failed] 712e06bc ursa-thinkcentre-m75q
[Finished] 965e761b ec2-t3-xlarge-us-east-2
[Failed] 965e761b test-mac-arm
[Failed] 965e761b ursa-i9-9960x
[Failed] 965e761b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@igor-suhorukov @anjakefala
ARROW-17431: [Java] MapBinder to bind Arrow Map type to DB column (ap…
5e336b8 
…ache#13941)

Typical real life Arrow datasets contain map of primitive type. This PR introduce MapBinder mapping of primitive types map entries

Authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@igor-suhorukov @zagto
ARROW-17431: [Java] MapBinder to bind Arrow Map type to DB column (ap…
bac735b 
…ache#13941)

Typical real life Arrow datasets contain map of primitive type. This PR introduce MapBinder mapping of primitive types map entries

Authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
@asfimport asfimport mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-suhorukov @ursabot @lidavidm