Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [CI][Java] Speed up JNI build #13908

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 17, 2022

Currently, Java JNI builds on Github Actions can take one hour due to a very long Arrow C++ build phase
(example: https://github.com/apache/arrow/runs/7881918943?check_suite_focus=true#step:6:3512).

Disable unused Arrow C++ components so as to make the C++ build faster.

Currently, Java JNI builds on Github Actions can take one hour due to a very long Arrow C++ build phase.

Disable unused Arrow C++ components so as to make the C++ build faster.
@pitrou
Copy link
Member Author

pitrou commented Aug 17, 2022

@pitrou
Copy link
Member Author

pitrou commented Aug 17, 2022

Passing build here: https://github.com/pitrou/arrow/runs/7885171489?check_suite_focus=true#step:6:2511
Note how the C++ build phase is down to 21 minutes without cache, while it could take 50 minutes before.

@pitrou
Copy link
Member Author

pitrou commented Aug 17, 2022

Will merge.

@pitrou pitrou merged commit 8474ee5 into apache:master Aug 17, 2022
@pitrou pitrou deleted the minor-java-jni-build branch August 17, 2022 19:04
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@ursabot
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = 4fa4007 and contender = 8474ee5. 8474ee5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.12% ⬆️0.37%] test-mac-arm
[Failed ⬇️1.1% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.89% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8474ee5a ec2-t3-xlarge-us-east-2
[Finished] 8474ee5a test-mac-arm
[Failed] 8474ee5a ursa-i9-9960x
[Finished] 8474ee5a ursa-thinkcentre-m75q
[Finished] 4fa40072 ec2-t3-xlarge-us-east-2
[Failed] 4fa40072 test-mac-arm
[Failed] 4fa40072 ursa-i9-9960x
[Finished] 4fa40072 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 18, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Currently, Java JNI builds on Github Actions can take one hour due to a very long Arrow C++ build phase
(example: https://github.com/apache/arrow/runs/7881918943?check_suite_focus=true#step:6:3512).

Disable unused Arrow C++ components so as to make the C++ build faster.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants