Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Rust][Docs] Update rust feature support docs #13879

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 15, 2022

The feature support matrix for Rust is about a year out of date, lets update it 😄

Website is https://arrow.apache.org/docs/status.html

@@ -81,11 +81,11 @@ Data Types
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Struct | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Map | ✓ | ✓ | ✓ | ✓ | | | ✓ |
| Map | ✓ | ✓ | ✓ | ✓ | | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

Comment on lines +86 to +88
| Dense Union | ✓ | ✓ | ✓ | | | | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Sparse Union | ✓ | ✓ | ✓ | | | | ✓ |
| Sparse Union | ✓ | ✓ | ✓ | | | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -94,7 +94,7 @@ Data Types
+===================+=======+=======+=======+============+=======+=======+=======+
| Dictionary | ✓ | ✓ (1) | ✓ | ✓ (1) | ✓ (1) | ✓ (1) | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Extension | ✓ | ✓ | ✓ | | | | ✓ |
| Extension | ✓ | ✓ | ✓ | | | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, but we support propagating the metadata which seems to be all that is required??

@@ -128,7 +128,7 @@ IPC Format
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
| Sparse tensors | ✓ | | | | | | |
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+
| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just added by @liukun4515 and @alamb in apache/arrow-rs#2369

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Comment on lines +159 to +163
| gRPC_ transport (grpc:, grpc+tcp:) | ✓ | ✓ | ✓ | | ✓ | | |
+--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+
| gRPC domain socket transport (grpc+unix:) | ✓ | ✓ | ✓ | | ✓ | | |
| gRPC domain socket transport (grpc+unix:) | ✓ | ✓ | ✓ | | ✓ | | |
+--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+
| gRPC + TLS transport (grpc+tls:) | ✓ | ✓ | ✓ | | ✓ | | |
| gRPC + TLS transport (grpc+tls:) | ✓ | ✓ | ✓ | | ✓ | | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow-flight uses tonic which supports uds and tls

@tustvold tustvold changed the title Update rust feature support docs MINOR: Update rust feature support docs Aug 15, 2022
@tustvold tustvold changed the title MINOR: Update rust feature support docs MINOR: [Rust][Docs]Update rust feature support docs Aug 15, 2022
@tustvold tustvold changed the title MINOR: [Rust][Docs]Update rust feature support docs MINOR: [Rust][Docs] Update rust feature support docs Aug 15, 2022
@@ -40,13 +40,13 @@ Data Types
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| UInt8/16/32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Float16 | | | ✓ | | | | ✓ |
| Float16 | | | ✓ | | | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Float32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Decimal128 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Decimal256 | ✓ | ✓ | ✓ | | ✓ | | ✓ |
| Decimal256 | ✓ | ✓ | ✓ | | ✓ | | ✓ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tustvold -- looks great to me. I noticed this the other day and I couldn't figure out where the docs were defined (I was looking in https://github.com/apache/arrow-site)

BTW i think there is a special script to do the commit/merge in this repo (rather than the big green button).

I think I caused issues by not using it in the recent past -- for penance I can go figure out the correct invocation and do so for this PR if you would like

@tustvold
Copy link
Contributor Author

I couldn't figure out where the docs were defined

I used the "Edit this page" button in the top right to work out where it was
image

I can go figure out the correct invocation and do so for this PR if you would like

That would be amazing, thank you

@alamb alamb merged commit a270afc into apache:master Aug 15, 2022
@alamb
Copy link
Contributor

alamb commented Aug 15, 2022

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ ./dev/merge_arrow_pr.sh 13879
ARROW_HOME = /Users/alamb/Software/arrow/dev
PROJECT_NAME = arrow

=== Pull Request #13879 ===
title	MINOR: [Rust][Docs] Update rust feature support docs
source	tustvold/update-rust-feature-support
target	master
url	https://api.github.com/repos/apache/arrow/pulls/13879
Minor PR.  Please ensure it meets guidelines for minor.


Proceed with merging pull request #13879? (y/n): y
Author 1: Raphael Taylor-Davies <[email protected]>
Pull request #13879 merged!
Merge hash: a270afc946398a0279b1971a315858d8b5f07e2d
Minor PR.  No JIRA issue to update.

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ 

@ursabot
Copy link

ursabot commented Aug 15, 2022

Benchmark runs are scheduled for baseline = bc1a16c and contender = a270afc. a270afc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.14% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a270afc9 ec2-t3-xlarge-us-east-2
[Failed] a270afc9 test-mac-arm
[Failed] a270afc9 ursa-i9-9960x
[Finished] a270afc9 ursa-thinkcentre-m75q
[Finished] bc1a16cd ec2-t3-xlarge-us-east-2
[Failed] bc1a16cd test-mac-arm
[Failed] bc1a16cd ursa-i9-9960x
[Finished] bc1a16cd ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 15, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
The feature support matrix for Rust is about a year out of date, lets update it 😄 

Website is https://arrow.apache.org/docs/status.html

Authored-by: Raphael Taylor-Davies <[email protected]>
Signed-off-by: Andrew Lamb <[email protected]>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
The feature support matrix for Rust is about a year out of date, lets update it 😄 

Website is https://arrow.apache.org/docs/status.html

Authored-by: Raphael Taylor-Davies <[email protected]>
Signed-off-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants