-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Rust][Docs] Update rust feature support docs #13879
Conversation
@@ -81,11 +81,11 @@ Data Types | |||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Struct | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | |||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Map | ✓ | ✓ | ✓ | ✓ | | | ✓ | | |||
| Map | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
| Dense Union | ✓ | ✓ | ✓ | | | ✓ | ✓ | | ||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| Sparse Union | ✓ | ✓ | ✓ | | | | ✓ | | ||
| Sparse Union | ✓ | ✓ | ✓ | | | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -94,7 +94,7 @@ Data Types | |||
+===================+=======+=======+=======+============+=======+=======+=======+ | |||
| Dictionary | ✓ | ✓ (1) | ✓ | ✓ (1) | ✓ (1) | ✓ (1) | ✓ | | |||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Extension | ✓ | ✓ | ✓ | | | | ✓ | | |||
| Extension | ✓ | ✓ | ✓ | | | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this one, but we support propagating the metadata which seems to be all that is required??
@@ -128,7 +128,7 @@ IPC Format | |||
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Sparse tensors | ✓ | | | | | | | | |||
+-----------------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Buffer compression | ✓ | ✓ (3) | ✓ | | | | ✓ | | |||
| Buffer compression | ✓ | ✓ (3) | ✓ | | | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just added by @liukun4515 and @alamb in apache/arrow-rs#2369
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
| gRPC_ transport (grpc:, grpc+tcp:) | ✓ | ✓ | ✓ | | ✓ | ✓ | | | ||
+--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| gRPC domain socket transport (grpc+unix:) | ✓ | ✓ | ✓ | | ✓ | | | | ||
| gRPC domain socket transport (grpc+unix:) | ✓ | ✓ | ✓ | | ✓ | ✓ | | | ||
+--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| gRPC + TLS transport (grpc+tls:) | ✓ | ✓ | ✓ | | ✓ | | | | ||
| gRPC + TLS transport (grpc+tls:) | ✓ | ✓ | ✓ | | ✓ | ✓ | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -40,13 +40,13 @@ Data Types | |||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| UInt8/16/32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | |||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | |||
| Float16 | | | ✓ | | | | ✓ | | |||
| Float16 | | | ✓ | | | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| Float32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| Decimal128 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | | ||
+-------------------+-------+-------+-------+------------+-------+-------+-------+ | ||
| Decimal256 | ✓ | ✓ | ✓ | | ✓ | | ✓ | | ||
| Decimal256 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tustvold -- looks great to me. I noticed this the other day and I couldn't figure out where the docs were defined (I was looking in https://github.com/apache/arrow-site)
BTW i think there is a special script to do the commit/merge in this repo (rather than the big green button).
I think I caused issues by not using it in the recent past -- for penance I can go figure out the correct invocation and do so for this PR if you would like
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ ./dev/merge_arrow_pr.sh 13879
ARROW_HOME = /Users/alamb/Software/arrow/dev
PROJECT_NAME = arrow
=== Pull Request #13879 ===
title MINOR: [Rust][Docs] Update rust feature support docs
source tustvold/update-rust-feature-support
target master
url https://api.github.com/repos/apache/arrow/pulls/13879
Minor PR. Please ensure it meets guidelines for minor.
Proceed with merging pull request #13879? (y/n): y
Author 1: Raphael Taylor-Davies <[email protected]>
Pull request #13879 merged!
Merge hash: a270afc946398a0279b1971a315858d8b5f07e2d
Minor PR. No JIRA issue to update.
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ |
Benchmark runs are scheduled for baseline = bc1a16c and contender = a270afc. a270afc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
The feature support matrix for Rust is about a year out of date, lets update it 😄 Website is https://arrow.apache.org/docs/status.html Authored-by: Raphael Taylor-Davies <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
The feature support matrix for Rust is about a year out of date, lets update it 😄 Website is https://arrow.apache.org/docs/status.html Authored-by: Raphael Taylor-Davies <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
The feature support matrix for Rust is about a year out of date, lets update it 😄
Website is https://arrow.apache.org/docs/status.html