Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and use to test FlightSQL server #13868

Merged
merged 24 commits into from
Aug 15, 2022
Merged

ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and use to test FlightSQL server #13868

merged 24 commits into from
Aug 15, 2022

Conversation

zeroshade
Copy link
Member

No description provided.

@zeroshade zeroshade requested review from lidavidm and pitrou August 12, 2022 21:45
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17359

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm approved these changes Aug 15, 2022
View reviewed changes
go/arrow/array/list.go Show resolved Hide resolved
go/arrow/flight/flightsql/schema_ref/reference_schemas.go Outdated Show resolved Hide resolved
go/arrow/flight/flightsql/client.go Show resolved Hide resolved
go/arrow/flight/flightsql/example/sqlite_info.go Outdated Show resolved Hide resolved
@lidavidm
Copy link
Member

It also looks like the integration tests have been failing due to JS issues, we should probably dig into that

@zeroshade
Copy link
Member Author

@lidavidm I was considering looking into the JS integration failure, I'm just not particularly familiar with the arrow JS library. Though it looks like it's a gulp issue on build. I'll take a brief look at it and see if i can discover anything obvious.

@lidavidm
Copy link
Member

@lidavidm I was considering looking into the JS integration failure, I'm just not particularly familiar with the arrow JS library. Though it looks like it's a gulp issue on build. I'll take a brief look at it and see if i can discover anything obvious.

See ARROW-17410

@domoritz do you have any idea what's going on? The JIRA links some related issues but I'm not quite sure what the actual resolution is (do we just need to upgrade a package?)

@zeroshade
Copy link
Member Author

@lidavidm @domoritz It looks like the remedy is to downgrade zlib to v1.2.11 until the fix in the linked issue gets released. I'll try testing it locally

@zeroshade zeroshade merged commit 569f932 into apache:master Aug 15, 2022
@zeroshade zeroshade deleted the arrow-17359-flight-sqlite branch August 15, 2022 21:10
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@zeroshade @ksuarez1423
ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and us…
40fb726 
…e to test FlightSQL server (apache#13868)

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@zeroshade @ksuarez1423
ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and us…
3c9c4c3 
…e to test FlightSQL server (apache#13868)

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = 7ecfcf0 and contender = 569f932. 569f932 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.41% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 569f932d ec2-t3-xlarge-us-east-2
[Finished] 569f932d test-mac-arm
[Failed] 569f932d ursa-i9-9960x
[Finished] 569f932d ursa-thinkcentre-m75q
[Finished] 7ecfcf03 ec2-t3-xlarge-us-east-2
[Finished] 7ecfcf03 test-mac-arm
[Failed] 7ecfcf03 ursa-i9-9960x
[Finished] 7ecfcf03 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 16, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@zeroshade @zagto
ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and us…
3dda4e5 
…e to test FlightSQL server (apache#13868)

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroshade @lidavidm @ursabot