-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17293: [Java][CI] Prune java nightly builds #13839
Conversation
|
.github/workflows/java_nightly.yml
Outdated
env: | ||
KEEP: ${{ github.event.inputs.keep || 14 }} | ||
run: | | ||
for i in `ls -t repo/org/apache/arrow`; do; find repo/org/apache/arrow/$i -mindepth 1 -maxdepth 1 -type d -print0 | xargs -0 ls -t -d | tail -n +$((KEEP + 1)) | xargs rm -rf; done | ||
- name: Show repo contents | ||
run: tree repo | ||
- name: Upload Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update this step with the new action and switches otherwise the locally deleted files wont be deleted from the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @assignUser , just added
.github/workflows/java_nightly.yml
Outdated
- shell: bash | ||
name: Show local repo sync from remote | ||
run: | | ||
for i in `ls -t repo/org/apache/arrow`; do; echo "- $i: $(find repo/org/apache/arrow/$i -mindepth 1 -maxdepth 1 -type d | wc -l | xargs) versions available"; done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use multiple lines for readability?
for i in ...; do
echo ...
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also change this line too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
for i in `ls -t repo/org/apache/arrow`; do | ||
echo "- $i: $(find repo/org/apache/arrow/$i -mindepth 1 -maxdepth 1 -type d \ | ||
| wc -l \ | ||
| xargs) versions available" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this | xargs
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xarg
in this case help us with one-line string trimming report about number of version available:
- flight-sql: 3 versions available
- arrow-vector: 7 versions available
- flight-grpc: 4 versions available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 15d6959 and contender = d7eea09. d7eea09 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
Prune java nightly builds Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Prune java nightly builds Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Prune java nightly builds Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Prune java nightly builds