Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go #13828

Merged
merged 14 commits into from
Aug 11, 2022

Conversation

zeroshade
Copy link
Member

@zeroshade zeroshade commented Aug 9, 2022

This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario.

As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go.

Also closes #12496

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

@zeroshade zeroshade force-pushed the arrow-17326-flight-sql branch from 37a8fa1 to 41ac019 Compare August 9, 2022 18:09
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really comment on the Go code, but things look reasonable here. I realized that for the Flight SQL RFC, I should split out all the new functionality into a separate integration test, though…

go/arrow/array/record_test.go Outdated Show resolved Hide resolved
@zeroshade
Copy link
Member Author

I'll give this till end of today and then merge if no one has any comments or asks me to wait for them to have a chance to look through it

@zeroshade zeroshade merged commit e8ed4c2 into apache:master Aug 11, 2022
@zeroshade zeroshade deleted the arrow-17326-flight-sql branch August 11, 2022 20:33
@ursabot
Copy link

ursabot commented Aug 12, 2022

Benchmark runs are scheduled for baseline = 89b39bc and contender = e8ed4c2. e8ed4c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.54% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.68% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e8ed4c2f ec2-t3-xlarge-us-east-2
[Finished] e8ed4c2f test-mac-arm
[Failed] e8ed4c2f ursa-i9-9960x
[Finished] e8ed4c2f ursa-thinkcentre-m75q
[Finished] 89b39bcd ec2-t3-xlarge-us-east-2
[Failed] 89b39bcd test-mac-arm
[Failed] 89b39bcd ursa-i9-9960x
[Finished] 89b39bcd ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 12, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario.

As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go.

Also closes apache#12496

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario.

As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go.

Also closes apache#12496

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FlightSQL][Go] Support for metadata requests
3 participants