-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go #13828
Conversation
37a8fa1
to
41ac019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really comment on the Go code, but things look reasonable here. I realized that for the Flight SQL RFC, I should split out all the new functionality into a separate integration test, though…
I'll give this till end of today and then merge if no one has any comments or asks me to wait for them to have a chance to look through it |
Benchmark runs are scheduled for baseline = 89b39bc and contender = e8ed4c2. e8ed4c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario. As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go. Also closes apache#12496 Authored-by: Matt Topol <[email protected]> Signed-off-by: Matt Topol <[email protected]>
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario. As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go. Also closes apache#12496 Authored-by: Matt Topol <[email protected]> Signed-off-by: Matt Topol <[email protected]>
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario.
As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go.
Also closes #12496