ARROW-17348: [C++] Add support for building bundled LZ4 with Visual C++ 2019 or later #13817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…++ 2019 or later LZ4 provides CMake configuration. We can add support for building bundled LZ4 with Visual C++ 2019 or later by using it. But this needs CMake 3.7 or later because ExternaProject_Add(SOURCE_SUBDIR) is supported since CMake 3.7.
|
|
|
@pykello You may want to test this on your environment. |
|
@github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release |
|
Revision: 699d274 Submitted crossbow builds: ursacomputing/crossbow @ actions-ab77688b21
|
|
@kou this built successfully in my environment with LZ4 enabled & with both Relwithdebinfo & Debug configs. So this solves the problems I faced earlier. Thanks. |
|
@pykello Thanks for confirming this! I merge this. |
|
Benchmark runs are scheduled for baseline = cc9b89a and contender = b3116fa. b3116fa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LZ4 provides CMake configuration. We can add support for building
bundled LZ4 with Visual C++ 2019 or later by using it.
But this needs CMake 3.7 or later because
ExternaProject_Add(SOURCE_SUBDIR) is supported since CMake 3.7.