Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Fix MSVC compiler error #13795

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 4, 2022

Downcast explicitly from double to long.

This fixes a regression introduced in ARROW-16521.

Downcast explicitly from double to long.

This fixes a regression introduced in ARROW-16521.
@pitrou
Copy link
Member Author

pitrou commented Aug 4, 2022

CI passed on my fork, will merge.

@pitrou pitrou merged commit 6d9a6a4 into apache:master Aug 4, 2022
@pitrou pitrou deleted the minor-appveyor-compiler-error branch August 4, 2022 12:13
@ursabot
Copy link

ursabot commented Aug 4, 2022

Benchmark runs are scheduled for baseline = 669009e and contender = 6d9a6a4. 6d9a6a4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.37% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 6d9a6a4a ec2-t3-xlarge-us-east-2
[Finished] 6d9a6a4a test-mac-arm
[Finished] 6d9a6a4a ursa-i9-9960x
[Finished] 6d9a6a4a ursa-thinkcentre-m75q
[Failed] 669009ed ec2-t3-xlarge-us-east-2
[Finished] 669009ed test-mac-arm
[Finished] 669009ed ursa-i9-9960x
[Finished] 669009ed ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants