ARROW-17175: [CI][macOS] macos-10.15 is deprecated and macos-latest is macos-11 #13684
Conversation
|
|
|
@github-actions crossbow submit homebrew-* wheel-macos-* |
|
Revision: 798b54e Submitted crossbow builds: ursacomputing/crossbow @ actions-e0531f4869
|
|
@github-actions crossbow submit homebrew-* |
|
Revision: 63f4ad8 Submitted crossbow builds: ursacomputing/crossbow @ actions-9751fb9f1c
|
|
Some of our github action builds for macos 10.15 have been failing today as per the deprecation schedule on this issue: |
|
As per this comment actions/runner-images#5583 (comment) macos-latest will be macos 12 after the transition. Also will this change be an issue for the wheel builds? I know we set 10.15 as the deployment target anyway but afaik it would still be better to test on 10.15? There was some discussion about this in regards to the self-hosted runners in crossbow @pitrou @jorisvandenbossche |
|
Autobrew is maintained by Jeroen Ooms and is necessary for the R package due to CRAN targeting EOL macos versions (see here). So removing the autobrew formula is not an option. I don't think IIUC the version manipulation in |
|
Thanks for sharing about the context.
The removed codes in |
|
@github-actions crossbow submit wheel-macos-* |
|
Revision: a011390 Submitted crossbow builds: ursacomputing/crossbow @ actions-3dbd7f7c62
|
We are working on 10.13 self-hosted runners specifically for the R auto-brew builds atm. As CRAN builds on 10.13 and will block our submission if we don't pass on it, we really want to make sure it works to avoid lengthy discussions with CRAN. So please do not remove those builds. What are the issues you had with the self-hosted mac runner? We will likely keep it deactivated as we have the new, extended capacity in crossbow that should take care of our mac build needs. (ex. autobrew :) ) |
Wow! I didn't know it! What |
|
Due to the 10.13 being eol homebrew does not work so we won't be able to use the normal R install actions but rather will have to customize the templates a bit. We will likely have separate tags for r-oldrel and r-release version (so maybe For now I would think it best/easiest to comment these tasks out from |
|
There is also https://issues.apache.org/jira/browse/ARROW-12590 which probably needs to happen now as the old formula is what is causing the issue on macos >= 11. I'll check it out We could than add a param/matrix for the runner so that we can run this for both 10.13 and >=11 |
|
Are the 3.10 wheel build failures new? |
| @@ -35,7 +35,7 @@ env: | |||
| jobs: | |||
| build: | |||
| name: Build wheel for OS X | |||
| runs-on: macos-10.15 | |||
| runs-on: macos-12 | |||
There was a problem hiding this comment.
Can we keep this at 11 for now?
There was a problem hiding this comment.
Yes.
I changed it to macos-latest that equals to macos-11 for now.
I tried macos-12 to resolve the crc32c related failure. But it's not unrelated. So we don't need to use macos-12 here.
|
The wheel failure is a pip installation failure of crc32c, which it now tries to install from source instead of using a wheel |
Which is weird, because binary wheels are provided. Perhaps need to update pip to the latest version first? |
|
It looks like the azure builds will also be affected https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=30742&view=logs&j=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf |
|
@github-actions crossbow submit wheel-macos-* |
|
@github-actions crossbow submit conda-osx-* |
|
Revision: 288fba4 Submitted crossbow builds: ursacomputing/crossbow @ actions-389e663b84
|
|
Revision: 288fba4 Submitted crossbow builds: ursacomputing/crossbow @ actions-85172d3456
|
…s macos-11 https://github.com/actions/virtual-environments#available-environments > macOS 11 macos-latest or macos-11 > macOS 10.15 deprecated macos-10.15
|
@github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release |
|
Revision: 05c717d Submitted crossbow builds: ursacomputing/crossbow @ actions-7896db46bb
|
|
@github-actions crossbow submit verify-rc-source--macos- |
|
Revision: 05c717d Submitted crossbow builds: ursacomputing/crossbow @ actions-8e344ac9dc
|
|
@github-actions crossbow submit verify-rc-source--macos- |
|
@github-actions crossbow submit verify-rc-binaries-wheels-macos-* |
|
Revision: 5b914e8 Submitted crossbow builds: ursacomputing/crossbow @ actions-fe8a0e2788
|
|
Revision: 5b914e8 Submitted crossbow builds: ursacomputing/crossbow @ actions-5d0dfa7647
|
|
@github-actions crossbow submit verify-rc-binaries-wheels-macos-* --param release=9.0.0 --param rc=2 |
|
Revision: 5b914e8 Submitted crossbow builds: ursacomputing/crossbow @ actions-4c5df1b5a6
|
|
This is ready. |
| name: Build wheel for OS X | ||
| runs-on: macos-10.15 | ||
| name: Build wheel for macOS | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
Because I don't think that we need exactly macos-11 for this. We specify MACOSX_DEPLOYMENT_TARGET explicitly for this job. So I think that we can generate logically same binaries regardless of macOS version.
If this doesn't depend on exactly macos-11 and we use macos-latest here, we don't need to update this again when macos-11 is deprecated.
Should we use macos-11 explicitly here? If so, why do we need exactly macos-11 here?
|
No objections? I'll merge this next week. |
There was a problem hiding this comment.
macos-latest will be macos-12 sometime soon but we can update the workflows once that actually happens :) I will change the autobrew and r nightly builds to use self-hosted 10.13 in #13769
|
I merge this. |
|
Benchmark runs are scheduled for baseline = 2092dce and contender = 01358f1. 01358f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…s macos-11 (apache#13684) https://github.com/actions/virtual-environments#available-environments > macOS 11 macos-latest or macos-11 > macOS 10.15 deprecated macos-10.15 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
https://github.com/actions/virtual-environments#available-environments