Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [Python] Adding .hypothesis directory to gitignore #13664

Merged
merged 2 commits into from
Jul 21, 2022
Merged

MINOR: [Python] Adding .hypothesis directory to gitignore #13664

merged 2 commits into from
Jul 21, 2022

Conversation

westonpace
Copy link
Member

@westonpace westonpace commented Jul 20, 2022 •
edited
Loading

No description provided.

pitrou
pitrou reviewed Jul 21, 2022
View reviewed changes
python/.gitignore Outdated
@@ -6,6 +6,7 @@ Makefile
cmake_install.cmake
build/
Testing/
.hypothesis/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it under "Python stuff" below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I put it just under the coverage rule.

@westonpace westonpace force-pushed the feature/MINOR--add-hypothesis-to-gitignore branch from 3b87469 to 121d80d Compare July 21, 2022 14:53
@pitrou
Copy link
Member

pitrou commented Jul 21, 2022

@westonpace Feel free to merge when CI passes!

@westonpace westonpace merged commit f01770d into apache:master Jul 21, 2022
@ursabot
Copy link

ursabot commented Jul 23, 2022

Benchmark runs are scheduled for baseline = b0734e6 and contender = f01770d. f01770d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.17% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.63% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] f01770de ec2-t3-xlarge-us-east-2
[Failed] f01770de test-mac-arm
[Failed] f01770de ursa-i9-9960x
[Finished] f01770de ursa-thinkcentre-m75q
[Failed] b0734e68 ec2-t3-xlarge-us-east-2
[Failed] b0734e68 test-mac-arm
[Failed] b0734e68 ursa-i9-9960x
[Finished] b0734e68 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonpace @pitrou @ursabot