Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach() #12842

Closed
wants to merge 2 commits into from

Conversation

paleolimbot
Copy link
Member

After ARROW-15818 (#12564) we get an extra message on package load because "engine" was added to arrow_info()$capabilities and few if any users will have this turned on for at least the next release:

library(arrow)
#> See arrow_info() for available features

This PR adds "engine" to the list of features we don't message users about and clarifies the message so that it's more clear why it's being shown:

library(arrow)
#> Some features of Arrow C++ are turned off. Run `arrow_info()` for more information.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

r/R/arrow-package.R Outdated Show resolved Hide resolved
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a small stylistic change on the error message that you can take or leave.

Co-authored-by: Jonathan Keane <[email protected]>
@paleolimbot
Copy link
Member Author

I like it!

@jonkeane jonkeane closed this in 961ec77 Apr 8, 2022
@ursabot
Copy link

ursabot commented Apr 10, 2022

Benchmark runs are scheduled for baseline = 58fe60f and contender = 961ec77. 961ec77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.17% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.17% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/482| 961ec771 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/467| 961ec771 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/468| 961ec771 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/477| 961ec771 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/481| 58fe60f5 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/466| 58fe60f5 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/467| 58fe60f5 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/476| 58fe60f5 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jcralmeida pushed a commit to rafael-telles/arrow that referenced this pull request Apr 19, 2022
…n .onAttach()

After ARROW-15818 (apache#12564) we get an extra message on package load because "engine" was added to `arrow_info()$capabilities` and few if any users will have this turned on for at least the next release:

```r
library(arrow)
#> See arrow_info() for available features
```

This PR adds "engine" to the list of features we don't message users about and clarifies the message so that it's more clear why it's being shown:

```r
library(arrow)
#> Some features of Arrow C++ are turned off. Run `arrow_info()` for more information.
```

Closes apache#12842 from paleolimbot/r-onattach

Lead-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
@paleolimbot paleolimbot deleted the r-onattach branch December 9, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants