-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach() #12842
Conversation
…ify package startup message
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a small stylistic change on the error message that you can take or leave.
Co-authored-by: Jonathan Keane <[email protected]>
I like it! |
Benchmark runs are scheduled for baseline = 58fe60f and contender = 961ec77. 961ec77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…n .onAttach() After ARROW-15818 (apache#12564) we get an extra message on package load because "engine" was added to `arrow_info()$capabilities` and few if any users will have this turned on for at least the next release: ```r library(arrow) #> See arrow_info() for available features ``` This PR adds "engine" to the list of features we don't message users about and clarifies the message so that it's more clear why it's being shown: ```r library(arrow) #> Some features of Arrow C++ are turned off. Run `arrow_info()` for more information. ``` Closes apache#12842 from paleolimbot/r-onattach Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Jonathan Keane <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>
After ARROW-15818 (#12564) we get an extra message on package load because "engine" was added to
arrow_info()$capabilities
and few if any users will have this turned on for at least the next release:This PR adds "engine" to the list of features we don't message users about and clarifies the message so that it's more clear why it's being shown: