-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-1689: [Python] Implement zero-copy conversions for DictionaryArray #1237
Conversation
Thanks - I wrote a test for this behaviour when working on my PR!
|
cb4980e
to
87db87a
Compare
Rebased and fixed flakes. The test case is failing, I will leave you to fix |
Looking at this now to see if I can fix the test case |
Change-Id: I477e3babec8bfdde952c4ff03193a23c304ef565
… no PyObject* is available to set as zero-copy ndarray base Change-Id: Ib3e8da682906ea941ef9b0294ad5175365e1aabd
87db87a
to
53342e8
Compare
Had to resort to a little bit of dark magic (the PyCapsule API) to handle zero-copy dictionaries. When the dictionary values are not zero-copyable (the test case had strings, I changed this to be integers), this still raises |
+1, will await builds |
@wesm Wow! Thanks for your great idea! I didn't get such idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
This PR closes ARROW-1689.
I want to add the zero-copy option after #1233 merged.