Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240

Closed
wants to merge 56 commits into from
Closed

ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240

wants to merge 56 commits into from

Commits on Feb 22, 2022

  1. added failing tests for timestamps

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    eaf2fe9 View commit details
    Browse the repository at this point in the history

  2. a more robust test

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    d7fee58 View commit details
    Browse the repository at this point in the history

  3. added with and without tz examples

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    9f6e2ba View commit details
    Browse the repository at this point in the history

  4. add the timezone if missing

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    eba6e74 View commit details
    Browse the repository at this point in the history

  5. simplify unit test

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    ec5e3a3 View commit details
    Browse the repository at this point in the history

  6. import rlang::inform

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2dd042a View commit details
    Browse the repository at this point in the history

  7. add rlang::import to namespace

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    4cf3f4a View commit details
    Browse the repository at this point in the history

  8. account for POSIXct vectors without the "tzone" attribute

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    3d9534e View commit details
    Browse the repository at this point in the history

  9. use missing() instead of is.null() to check for a missing attribute

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    f38a293 View commit details
    Browse the repository at this point in the history

  10. add a test for message and do not use missing() to check for missin… 

    …g attributes
    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0238aa5 View commit details
    Browse the repository at this point in the history

  11. use any() instead of | when looking for a missing "tzone" attri… 

    …bute
    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1a5fe71 View commit details
    Browse the repository at this point in the history

  12. remove tests for array from POSIXct without timezone

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2a2065a View commit details
    Browse the repository at this point in the history

  13. no longer inform

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    69df927 View commit details
    Browse the repository at this point in the history

  14. remove message expectation

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    135af60 View commit details
    Browse the repository at this point in the history

  15. remove inaccurate comment

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    ea4ef87 View commit details
    Browse the repository at this point in the history

  16. additional unit tests for POSIXct -> array

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    d9aa10a View commit details
    Browse the repository at this point in the history

  17. switch test to "Pacific/Marquesas" as improbable timezone

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0bd4eab View commit details
    Browse the repository at this point in the history

  18. remove handling of missing or empty tzone from Array

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    e1b1199 View commit details
    Browse the repository at this point in the history

  19. changed rare timezone in tests to "Pacific/Marquesas"

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5466d39 View commit details
    Browse the repository at this point in the history

  20. added systzone symbol

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2742681 View commit details
    Browse the repository at this point in the history

  21. update the definition of InferArrowTypeFromVector

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    a1540dc View commit details
    Browse the repository at this point in the history

  22. update the type infer from REALSXP too

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    05ebbb9 View commit details
    Browse the repository at this point in the history

  23. found what looks to be the right incantation for calling R functionality

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    463bce3 View commit details
    Browse the repository at this point in the history

  24. stop going through symbols:: for Sys.timezone()

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    388ff7e View commit details
    Browse the repository at this point in the history

  25. call Sys.timezone() directly

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    79460d1 View commit details
    Browse the repository at this point in the history

  26. testing TZ = NA and TZ = NULL both result in a NULL "tzone" a… 

    …ttribute
    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    6b27059 View commit details
    Browse the repository at this point in the history

  27. skip 1 test on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    6a633b9 View commit details
    Browse the repository at this point in the history

  28. skip test 2 on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    09f3382 View commit details
    Browse the repository at this point in the history

  29. skip test 3 on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5d455a9 View commit details
    Browse the repository at this point in the history

  30. skip test 4 & 5 on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1816861 View commit details
    Browse the repository at this point in the history

  31. skip tests 6, 7, 8, 9 & 10 on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    bf5b374 View commit details
    Browse the repository at this point in the history

  32. skip tests 11, 12, 13, and 14 on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    f9552f4 View commit details
    Browse the repository at this point in the history

  33. checking to see if ignore_attr helps when comparing objects

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b0ffa4f View commit details
    Browse the repository at this point in the history

  34. ignore attributes only on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    68ccb24 View commit details
    Browse the repository at this point in the history

  35. one more ignore attributes on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    8bac047 View commit details
    Browse the repository at this point in the history

  36. defined and used on_windows() to selectively ignore attributes in e… 

    …xpectations
    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    e3f6a5b View commit details
    Browse the repository at this point in the history

  37. ignoring attributes for some more of the failing tests

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    28d193f View commit details
    Browse the repository at this point in the history

  38. some more attributes ignored

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    528647a View commit details
    Browse the repository at this point in the history

  39. ignoring more attribute checks on windows

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5638c6b View commit details
    Browse the repository at this point in the history

  40. un-skip tests on win

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    166c708 View commit details
    Browse the repository at this point in the history

  41. ignore attributes on windows for yday extractions

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    6ca5a4e View commit details
    Browse the repository at this point in the history

  42. added a bunch of TODOs related to ARROW-13168

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    41b580f View commit details
    Browse the repository at this point in the history

  43. trying something

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    daac293 View commit details
    Browse the repository at this point in the history

  44. skip 1 test + datetime column OS aware

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0415048 View commit details
    Browse the repository at this point in the history

  45. try Jon's suggestion

    @dragosmg
    dragosmg committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    d543415 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. some cleanup

    @dragosmg
    dragosmg committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    3343026 View commit details
    Browse the repository at this point in the history

  2. more cleanup

    @dragosmg
    dragosmg committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    fa510ed View commit details
    Browse the repository at this point in the history

  3. one more

    @dragosmg
    dragosmg committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    d9d1d15 View commit details
    Browse the repository at this point in the history

  4. another one

    @dragosmg
    dragosmg committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    f472103 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into timestampts_missing_timezone

    @dragosmg
    dragosmg authored Mar 30, 2022
    Configuration menu
    Copy the full SHA
    c071d07 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. removed the on_windows() skip helper

    @dragosmg
    dragosmg committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    876c483 View commit details
    Browse the repository at this point in the history

  2. use withr::with_timezone()

    @dragosmg
    dragosmg committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    5903fb2 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. erroring with with_timezone("" ...) instead of `with_envvar(c(TZ = … 

    …"") ...)`
    @dragosmg
    dragosmg committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    de58c8d View commit details
    Browse the repository at this point in the history

  2. add test with a different timezone

    @dragosmg
    dragosmg committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    e31bf0a View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. removed rlang::inform() import

    @dragosmg
    dragosmg committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e5039a8 View commit details
    Browse the repository at this point in the history

  2. switched back to withr::with_envvar(c(TZ = "")) instead of `withr::… 

    …with_timezone("")`
    @dragosmg
    dragosmg committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    fb19ce8 View commit details
    Browse the repository at this point in the history