-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14311: [C++] Make GCS FileSystem tests faster #11406
ARROW-14311: [C++] Make GCS FileSystem tests faster #11406
Conversation
@pitrou would you be able to test this in your environment? I have good reason to believe ( |
It works indeed :-)
|
(1.5s make still be a bit long once there are a lot of tests, but perhaps it's not really possible to make it faster) |
I will see what I tolerate. At some point I might start the testbench once, and then isolate the tests using different buckets or something similar. |
Avoid using the default credentials for the unit test. In some environments these can be very slow to initialize, as they test several different potential sources of credentials, some including HTTP requests.
Is there something else I need to do here or can we merge this PR? |
Ping. Is there are reason we cannot merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this.
@pitrou If you have any concern, please write it here.
Benchmark runs are scheduled for baseline = 1bac505 and contender = 1b7178d. 1b7178d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
@coryan Sorry for the delay. I was on holiday. |
Avoid using the default credentials for the unit test. In some environments these can be very slow to initialize, as they test several different potential sources of credentials, some including HTTP requests. Closes apache#11406 from coryan/ARROW-14311-GCS-filesystem-now-uses-insecure-credentials-for-http Authored-by: Carlos O'Ryan <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Avoid using the default credentials for the unit test. In some
environments these can be very slow to initialize, as they test several
different potential sources of credentials, some including HTTP
requests.