ARROW-12622: [Python] Fix segfault in read_csv when not on main thread #10227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
changed the title
|
AppVeyor build: https://ci.appveyor.com/project/lidavidm/arrow/builds/38981953 |
DileepSrigiri
pushed a commit
to DileepSrigiri/arrow
that referenced
this pull request
May 6, 2021
An uninitialized StopToken caused segfaults if you ever called read_csv with cancellation disabled or when not on the main thread (e.g. if used in a Flight server). If we have a 4.0.1 I think this qualifies as a regression. Closes apache#10227 from lidavidm/arrow-12622 Authored-by: David Li <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
May 17, 2021
An uninitialized StopToken caused segfaults if you ever called read_csv with cancellation disabled or when not on the main thread (e.g. if used in a Flight server). If we have a 4.0.1 I think this qualifies as a regression. Closes apache#10227 from lidavidm/arrow-12622 Authored-by: David Li <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
An uninitialized StopToken caused segfaults if you ever called read_csv with cancellation disabled or when not on the main thread (e.g. if used in a Flight server). If we have a 4.0.1 I think this qualifies as a regression. Closes apache#10227 from lidavidm/arrow-12622 Authored-by: David Li <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
An uninitialized StopToken caused segfaults if you ever called read_csv with cancellation disabled or when not on the main thread (e.g. if used in a Flight server). If we have a 4.0.1 I think this qualifies as a regression. Closes apache#10227 from lidavidm/arrow-12622 Authored-by: David Li <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An uninitialized StopToken caused segfaults if you ever called read_csv with cancellation disabled or when not on the main thread (e.g. if used in a Flight server). If we have a 4.0.1 I think this qualifies as a regression.