[C++][Compute] Move Grouper tests into grouper_test.cc #45279
Comments
pitrou
added a commit
to pitrou/arrow
that referenced
this issue
Jan 16, 2025
pitrou
added a commit
that referenced
this issue
Jan 16, 2025
…45280) ### What changes are included in this PR? 1. Move tests for the Grouper and RowSegmenter implementations to `arrow/compute/row/grouper_test.cc` where they belong (this also makes `acero/hash_aggregate_test.cc` slightly shorter) 2. Introduce a `arrow_compute_testing` object library to hold compute-related testing utilities 3. Remove duplicate definitions of `ExecBatchFromJSON` from Dataset and Acero 4. Make `arrow/compute/kernels/test_util.h` internal ### Are these changes tested? Yes, by existing tests and CI. ### Are there any user-facing changes? No. * GitHub Issue: #45279 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
Issue resolved by pull request 45280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Currently, many tests for the Grouper and KeySegmenter implementations are present in
acero/hash_aggregate_test.cc. We should move them intoarrow/compute/row/grouper_test.ccwhere they belong.This will also make
hash_aggregate_test.ccslightly smaller and shorter to compile.Component(s)
C++
The text was updated successfully, but these errors were encountered: